Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed cpplint issues and updated docs #2830

Merged
merged 1 commit into from
Feb 27, 2020
Merged

fixed cpplint issues and updated docs #2830

merged 1 commit into from
Feb 27, 2020

Conversation

StrikerRUS
Copy link
Collaborator

Refer to #1990 and #2801.

jameslamb
jameslamb approved these changes Feb 26, 2020
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Unsure on the impact of removing virtual from GetName() but if CI passes then you are good!

@StrikerRUS
Copy link
Collaborator Author

@jameslamb

cpplint argued

src/objective/rank_objective.hpp:72:  "virtual" is redundant since function is already declared as "override"  [readability/inheritance] [4]

@jameslamb
Copy link
Collaborator

@jameslamb

cpplint argued

src/objective/rank_objective.hpp:72:  "virtual" is redundant since function is already declared as "override"  [readability/inheritance] [4]

oh ok! I did not know about override

@guolinke guolinke merged commit b305a43 into master Feb 27, 2020
@StrikerRUS StrikerRUS deleted the cpplint branch February 27, 2020 16:41
@guolinke guolinke added the doc label Mar 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guolinke guolinke guolinke approved these changes

@jameslamb jameslamb jameslamb approved these changes

@chivee chivee Awaiting requested review from chivee

@Laurae2 Laurae2 Awaiting requested review from Laurae2

Assignees
No one assigned
Labels
doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StrikerRUS @jameslamb @guolinke