-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] upgrade R to 4.0.5 in CI #4158
Conversation
On Mac, this is failing with the error observed in #4147 (comment)
On ubuntu, looks I'm not sure what the root problem is. I tried removing
|
This is the same issue I faced during restricting CMake version recently. |
Right, I tried this and it did not work. Let me add more details on what I meant by "doesn't work". Adding
Trying to add
So maybe we just cannot update to R 4.0.5 on Ubuntu 20.04 yet. Hopefully if we check back in a few days, it will be possible. |
Ok I just retried this locally and it seems like just installing To test locally, I replicated LightGBM's CI environment with the commands below. It isn't identical (since R jobs run in the Azure DevOps Pasting my testing setup here just in case it's useful as a reference in the future. docker run \
-v $(pwd):/opt/LightGBM \
-w /opt/LightGBM \
--env BUILD_DIRECTORY=/opt/LightGBM \
--env COMPILER=gcc \
--env GITHUB_ACTIONS="true" \
--env IN_UBUNTU_LATEST_CONTAINER="true" \
--env OS_NAME=linux \
--env R_VERSION=4.0 \
--env R_BUILD_TYPE=cran \
--env SETUP_CONDA="true" \
--env TASK=r-package \
-it \
ubuntu:latest \
/bin/bash
apt update -y
apt install -y sudo
sudo apt-get install -y dirmngr
./.ci/setup.sh
./.ci/test.sh |
Sad, this is still failing with the same error. Ok, I'll keep investigating locally. |
@jameslamb What do you think about the following trick? |
Nice trick! But that only works if you are not pinning the version of R (further down in that file, you have an unpinned For example. LightGBM/.ci/test_r_package.sh Line 33 in b674439
So I think it makes sense for |
ok merging this one with admin rights, since lack of it is starting to cause others to fail (#4167 (comment)) and since if we rebuild it, it will fail on the |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
R 4.0.5 ("Shake and Throw") was released two days ago (https://stat.ethz.ch/pipermail/r-announce/2021/000668.html).
This PR updates this project's continuous integration environments to use the new version. Linking #3763.
Release notes: https://cran.r-project.org/bin/windows/base/NEWS.R-4.0.5.html