Support checking gdb.exe on Windows #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds additional checks to look for gdb on Windows. If a user does not specify miDebuggerPath, we will check for gdb and gdb.exe in PATH. If a miDebuggerPath is provided and does not supply any directory, we will search that binary and binary.exe in PATH.
pieandcakes
requested changes
May 16, 2020
gregg-miskelly
approved these changes
May 18, 2020
pieandcakes
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional checks to look for gdb on Windows.
If a user does not specify miDebuggerPath, we will check for gdb and
gdb.exe in PATH. If a miDebuggerPath is provided and does not supply any
directory, we will search that binary and binary.exe in PATH.
microsoft/vscode-cpptools#3076