Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support checking gdb.exe on Windows #1001

Merged
merged 3 commits into from
May 18, 2020
Merged

Support checking gdb.exe on Windows #1001

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8cb291f
Support checking gdb.exe on Windows
WardenGnaw May 16, 2020
6760a4c
Addressing PR issue
WardenGnaw May 16, 2020
1f7a3db
More PR issue fixes
WardenGnaw May 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/MICore/LaunchOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,6 +541,8 @@ private static string ResolveFromPath(string command)
{
string pathVar = System.Environment.GetEnvironmentVariable("PATH");

bool checkForWindowsExe = PlatformUtilities.IsWindows() && String.IsNullOrEmpty(Path.GetExtension(command));

// Check each portion of the PATH environment variable to see if it contains the requested file
foreach (string pathPart in pathVar.Split(Path.PathSeparator))
{
Expand All @@ -551,6 +553,15 @@ private static string ResolveFromPath(string command)
{
gregg-miskelly marked this conversation as resolved.
Show resolved Hide resolved
return candidate;
}

if (checkForWindowsExe)
{
string exeCandidate = candidate + ".exe";
if (File.Exists(exeCandidate))
{
return exeCandidate;
}
}
}

return null;
Expand Down