Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display function return values #1036

Merged
merged 1 commit into from
Sep 18, 2020
Merged

display function return values #1036

merged 1 commit into from
Sep 18, 2020

Conversation

Trass3r
Copy link
Contributor

@Trass3r Trass3r commented Aug 26, 2020 •
edited
Loading

Tested on gdb 8/10.
Fixes #1027.

Trass3r
Trass3r commented Aug 26, 2020
View reviewed changes
src/MIDebugEngine/Engine.Impl/DebuggedProcess.cs
{
string resultVar = results.Results.TryFindString("gdb-result-var"); // a gdb value history var like "$1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately we only get the name of the caller instead of the callee here.

@Trass3r
Copy link
Contributor Author

Trass3r commented Sep 5, 2020 •
edited
Loading

@WardenGnaw
I cleaned it up.

@WardenGnaw WardenGnaw changed the base branch from master to main September 11, 2020 21:28
WardenGnaw
WardenGnaw requested changes Sep 16, 2020
View reviewed changes
Copy link
Member

@WardenGnaw WardenGnaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this only support return value on step-out until GDB supports getting a return value?

src/MIDebugEngine/Engine.Impl/DebuggedProcess.cs Outdated Show resolved Hide resolved
@Trass3r
Copy link
Contributor Author

Trass3r commented Sep 17, 2020

Done. Yes only works on step out.

@WardenGnaw
Copy link
Member

@Trass3r Thank you again for your contribution!

@WardenGnaw WardenGnaw merged commit 7bde94d into microsoft:main Sep 18, 2020
@Trass3r Trass3r deleted the return-values branch September 18, 2020 00:03
@Trass3r Trass3r mentioned this pull request Jun 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WardenGnaw WardenGnaw WardenGnaw approved these changes

@gregg-miskelly gregg-miskelly gregg-miskelly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display function return value
3 participants
@Trass3r @WardenGnaw @gregg-miskelly