-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LogPoint Issue + Add IgnoreResponseOrder in DAR #1208
Conversation
Customer reported in v1.6.0 that LogPoints stopped working. This was due to IDebugBreakpointEvent2.EnumBreakpoints returning the same IEnumDebugBoundBreakpoints2. The fix was to save IDebugBoundBreakpoint2[] in the event and return a new IEnumDebugBoundBreakpoints2 object per call. Added a test for logpoints and fixed up ConsoleEvent to be OutputEvent since thats what it should actually be.
To make these issues easier to debug in the future, I would suggest we change the expected format to be more like the actual. Something like:
Refers to: test/DebugAdapterRunner/DebugAdapterCommand.cs:242 in 7249fbd. [](commit_id = 7249fbd, deletion_comment = False) |
Example Test failure log:
|
Two nits:
I think you want a new line after
Since it will show up in the log, I would suggest renaming 'Seen' to 'FoundMatch' |
Customer reported in v1.6.0 that LogPoints stopped working and are treated like regular breakpoints.
This was due to IDebugBreakpointEvent2.EnumBreakpoints returning the
same IEnumDebugBoundBreakpoints2.
The fix was to save IDebugBoundBreakpoint2[] in the event and return a
new IEnumDebugBoundBreakpoints2 object per call.
Added a test for logpoints and fixed up ConsoleEvent to be OutputEvent
since thats what it should actually be.
Added flag
IgnoreResponseOrder
to allow looking at historical responses to find out if the expected response occurred before.