Fix LogPoint Issue + Add IgnoreResponseOrder in DAR

src/MIDebugEngine/AD7.Impl/AD7Events.cs

@@ -541,9 +541,9 @@ internal sealed class AD7BreakpointEvent : AD7StoppingEvent, IDebugBreakpointEve
     {
         public const string IID = "501C1E21-C557-48B8-BA30-A1EAB0BC4A74";
 
-        private IEnumDebugBoundBreakpoints2 _boundBreakpoints;
+        IDebugBoundBreakpoint2[] _boundBreakpoints;
 
-        public AD7BreakpointEvent(IEnumDebugBoundBreakpoints2 boundBreakpoints)
+        public AD7BreakpointEvent(IDebugBoundBreakpoint2[] boundBreakpoints)
         {
             _boundBreakpoints = boundBreakpoints;
         }
@@ -552,7 +552,7 @@ public AD7BreakpointEvent(IEnumDebugBoundBreakpoints2 boundBreakpoints)
 
         int IDebugBreakpointEvent2.EnumBreakpoints(out IEnumDebugBoundBreakpoints2 ppEnum)
         {
-            ppEnum = _boundBreakpoints;
+            ppEnum = new AD7BoundBreakpointsEnum(_boundBreakpoints);
             return Constants.S_OK;
         }
 

src/MIDebugEngine/Engine.Impl/EngineCallback.cs

@@ -199,9 +199,7 @@ public void OnBreakpoint(DebuggedThread thread, ReadOnlyCollection<object> clien
             // should notify each bound breakpoint that it has been hit and evaluate conditions here.
             // The sample engine does not support these features.
 
-            AD7BoundBreakpointsEnum boundBreakpointsEnum = new AD7BoundBreakpointsEnum(boundBreakpoints);
-
-            AD7BreakpointEvent eventObject = new AD7BreakpointEvent(boundBreakpointsEnum);
+            AD7BreakpointEvent eventObject = new AD7BreakpointEvent(boundBreakpoints);
 
             AD7Thread ad7Thread = (AD7Thread)thread.Client;
             Send(eventObject, AD7BreakpointEvent.IID, ad7Thread);

test/CppTests/Tests/BreakpointTests.cs

@@ -154,6 +154,48 @@ public void FunctionBreakpointsBasic(ITestSettings settings)
             }
         }
 
+        [Theory]
+        [DependsOnTest(nameof(CompileKitchenSinkForBreakpointTests))]
+        [RequiresTestSettings]
+        public void LineLogBreakpointsBasic(ITestSettings settings)
+        {
+            this.TestPurpose("Tests basic operation of line breakpoints with a LogPoint");
+            this.WriteSettings(settings);
+
+            IDebuggee debuggee = SinkHelper.Open(this, settings.CompilerSettings, DebuggeeMonikers.KitchenSink.Breakpoint);
+
+            using (IDebuggerRunner runner = CreateDebugAdapterRunner(settings))
+            {
+                this.Comment("Configure launch");
+                runner.Launch(settings.DebuggerSettings, debuggee, "-fCalling");
+
+                // These keep track of all the breakpoints in a source file
+                SourceBreakpoints callingBreakpoints = debuggee.Breakpoints(SinkHelper.Calling, 48);
+
+                this.Comment("Set initial breakpoints");
+                runner.SetBreakpoints(callingBreakpoints);
+
+                this.Comment("Launch and run until first breakpoint");
+                runner.Expects.HitBreakpointEvent(SinkHelper.Calling, 48)
+                              .AfterConfigurationDone();
+
+                this.Comment("Set a breakpoint while in break mode");
+                callingBreakpoints.Add(52, null, "Log Message");
+                runner.SetBreakpoints(callingBreakpoints);
+
+                this.Comment("Continue until newly-added breakpoint");
+                runner.Expects.OutputEvent("Log Message\n", CategoryValue.Console)
+                              .AfterContinue();
+
+                this.Comment("Continue until end");
+                runner.Expects.ExitedEvent()
+                              .TerminatedEvent()
+                              .AfterContinue();
+
+                runner.DisconnectAndVerify();
+            }
+        }
+
         [Theory]
         [DependsOnTest(nameof(CompileKitchenSinkForBreakpointTests))]
         [RequiresTestSettings]

test/DebuggerTesting/OpenDebug/Commands/SetBreakpointsCommand.cs

@@ -18,10 +18,12 @@ public sealed class SetBreakpointsCommandArgs : JsonValue
     {
         public sealed class SourceBreakpoint
         {
-            public SourceBreakpoint(int line, int? column, string condition)
+            public SourceBreakpoint(int line, int? column, string condition, string logMessage)
             {
                 this.line = line;
+                this.column = column;
                 this.condition = condition;
+                this.logMessage = logMessage;
             }
 
             public int line;
@@ -31,6 +33,9 @@ public SourceBreakpoint(int line, int? column, string condition)
 
             [JsonProperty(DefaultValueHandling = DefaultValueHandling.Ignore)]
             public string condition;
+
+            [JsonProperty(DefaultValueHandling = DefaultValueHandling.Ignore)]
+            public string logMessage;
         }
 
         public Source source = new Source();
@@ -58,7 +63,7 @@ public SourceBreakpoints(string sourceRoot, string relativePath)
         {
             Parameter.ThrowIfNull(sourceRoot, nameof(sourceRoot));
             Parameter.ThrowIfNull(relativePath, nameof(relativePath));
-            this.Breakpoints = new Dictionary<int, string>();
+            this.Breakpoints = new Dictionary<int, SetBreakpointsCommandArgs.SourceBreakpoint>();
             this.RelativePath = relativePath;
             this.FullPath = Path.Combine(sourceRoot, relativePath);
         }
@@ -67,11 +72,11 @@ public SourceBreakpoints(string sourceRoot, string relativePath)
 
         #region Add/Remove
 
-        public SourceBreakpoints Add(int lineNumber, string condition = null)
+        public SourceBreakpoints Add(int lineNumber, string condition = null, string logMessage = null)
         {
             if (this.Breakpoints.ContainsKey(lineNumber))
                 throw new RunnerException("Breakpoint line {0} already added to file {1}.", lineNumber, this.RelativePath);
-            this.Breakpoints.Add(lineNumber, condition);
+            this.Breakpoints.Add(lineNumber, new SetBreakpointsCommandArgs.SourceBreakpoint(lineNumber, null, condition, logMessage));
             return this;
         }
 
@@ -97,7 +102,7 @@ public SourceBreakpoints Remove(int lineNumber)
         /// Keep the breakpoint info in a dictionary indexed by line number.
         /// Store the condition as the value.
         /// </summary>
-        public IDictionary<int, string> Breakpoints { get; private set; }
+        public IDictionary<int, SetBreakpointsCommandArgs.SourceBreakpoint> Breakpoints { get; private set; }
     }
 
     #endregion
@@ -112,10 +117,7 @@ public SetBreakpointsCommand(SourceBreakpoints sourceBreakpoints) :
             this()
         {
             this.Args.source.path = sourceBreakpoints.FullPath;
-            IDictionary<int, string> breakpoints = sourceBreakpoints.Breakpoints;
-            this.Args.breakpoints = breakpoints.Select(x =>
-                    new SetBreakpointsCommandArgs.SourceBreakpoint(x.Key, null, x.Value)
-                ).ToArray();
+            this.Args.breakpoints = sourceBreakpoints.Breakpoints.Select(x => x.Value).ToArray();
             this.Args.lines = this.Args.breakpoints.Select(x => x.line).ToArray();
         }
 

test/DebuggerTesting/OpenDebug/Events/OutputEvent.cs

@@ -0,0 +1,43 @@
+// // Copyright (c) Microsoft. All rights reserved.
+// // Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+using System;
+
+namespace DebuggerTesting.OpenDebug.Events
+{
+    public enum CategoryValue
+    {
+        Console = 0,
+        Stdout = 1,
+        Stderr = 2,
+        Telemetry = 3,
+        Unknown = Int32.MaxValue
+    }
+
+    public sealed class OutputEventValue : EventValue
+    {
+        public sealed class Body
+        {
+            public string output;
+
+            public string category;
+        }
+
+        public Body body = new Body();
+    }
+
+    public sealed class OutputEvent : Event<OutputEventValue>
+    {
+        public OutputEvent(string text, CategoryValue category) : base("output")
+        {
+            this.ExpectedResponse.body.category = GeCategory(category);
+            this.ExpectedResponse.body.output = text;
+        }
+
+        private static string GeCategory(CategoryValue category)
+        {
+            Parameter.ThrowIfIsInvalid(category, CategoryValue.Unknown, nameof(category));
+            return category.ToString().ToLowerInvariant();
+        }
+    }
+}

test/DebuggerTesting/OpenDebug/RunBuilder.cs

@@ -106,9 +106,9 @@ public static IRunBuilder FunctionBreakpointChangedEvent(this IRunBuilder runBui
             return runBuilder.Event(new BreakpointEvent(reason, startLine, endLine));
         }
 
-        public static IRunBuilder ConsoleEvent(this IRunBuilder runBuilder, string text)
+        public static IRunBuilder OutputEvent(this IRunBuilder runBuilder, string text, CategoryValue category)
         {
-            return runBuilder.Event(new ConsoleEvent(text));
+            return runBuilder.Event(new OutputEvent(text, category));
         }
 
         #endregion