You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
During bulk register, existing metrics from the results db are loaded as strings as that is how they are stored.
However, applying self._adjust_signs_df to the string target columns results in un-intended results, especially when in a max case.
The string column *= -1 results in empty strings, which fail to cast into float later on in bulk register.
This issue probably never turned up in min cases as the string columns *= 1 has no effect.
The casting to float should probably be done on all target columns before adjusting signs.
Example output from the debug terminal:
The text was updated successfully, but these errors were encountered:
Closesmicrosoft#785
Also, add more unit tests to make sure the optimizer handles string
inputs correctly.
---------
Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
During bulk register, existing metrics from the results db are loaded as strings as that is how they are stored.
However, applying
self._adjust_signs_df
to the string target columns results in un-intended results, especially when in amax
case.The string column *= -1 results in empty strings, which fail to cast into
float
later on in bulk register.This issue probably never turned up in
min
cases as the string columns *= 1 has no effect.The casting to float should probably be done on all target columns before adjusting signs.
Example output from the debug terminal:
The text was updated successfully, but these errors were encountered: