Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resume experiments fail when trying to bulk register previous metrics to the optimizer #785

Closed
eujing opened this issue Jul 10, 2024 · 0 comments · Fixed by #789
Closed

Comments

@eujing
Copy link
Contributor

eujing commented Jul 10, 2024

During bulk register, existing metrics from the results db are loaded as strings as that is how they are stored.

However, applying self._adjust_signs_df to the string target columns results in un-intended results, especially when in a max case.
The string column *= -1 results in empty strings, which fail to cast into float later on in bulk register.
This issue probably never turned up in min cases as the string columns *= 1 has no effect.

The casting to float should probably be done on all target columns before adjusting signs.

image

Example output from the debug terminal:
image

bpkroth added a commit to bpkroth/MLOS that referenced this issue Jul 22, 2024
Closes microsoft#785 

Also, add more unit tests to make sure the optimizer handles string
inputs correctly.

---------

Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant