Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the coercion of scores to floats in the optimizer #789

Merged
merged 20 commits into from
Jul 22, 2024
Merged

Fix the coercion of scores to floats in the optimizer #789

merged 20 commits into from
Jul 22, 2024

Conversation

motus
Copy link
Member

@motus motus commented Jul 10, 2024 •
edited
Loading

Closes #785

Also, add more unit tests to make sure the optimizer handles string inputs correctly.

@motus motus added bug Something isn't working ready for review Ready for review mlos-bench labels Jul 10, 2024
@motus motus self-assigned this Jul 10, 2024
@motus motus requested a review from a team as a code owner July 10, 2024 21:54
@motus motus mentioned this pull request Jul 10, 2024
Closed
@motus motus enabled auto-merge (squash) July 11, 2024 00:31
@bpkroth bpkroth changed the title Fix the coercion of scrores to floats in the optimizer Fix the coercion of scores to floats in the optimizer Jul 12, 2024
motus and others added 13 commits July 12, 2024 14:41
@motus
add more unit tests for _adjust_signs_df() method
973a2d4
@motus
Merge branch 'sergiym/opt/score_sign' of https://github.com/motus/MLOS …
ee3d975 
…into sergiym/opt/score_sign
@motus
Merge branch 'main' of https://github.com/microsoft/MLOS into sergiym…
e2e901f 
…/opt/score_sign
@motus
black formatting
571e39d
@motus
Merge branch 'main' into sergiym/opt/score_sign
d172d1c
@motus
Merge branch 'main' of https://github.com/microsoft/MLOS into sergiym…
d08639a 
…/opt/score_sign
@motus
Merge branch 'sergiym/opt/score_sign' of https://github.com/motus/MLOS …
9a4863c 
…into sergiym/opt/score_sign
@motus
Merge branch 'main' into sergiym/opt/score_sign
8b0dac9
@motus
Merge branch 'main' of https://github.com/microsoft/MLOS into sergiym…
cad4c56 
…/opt/score_sign
@motus
Merge branch 'sergiym/opt/score_sign' of https://github.com/motus/MLOS …
1a34faa 
…into sergiym/opt/score_sign
@motus
docformatter fixes
b8f11ab
@motus
Merge branch 'main' of https://github.com/microsoft/MLOS into sergiym…
602b493 
…/opt/score_sign
@bpkroth
Merge branch 'main' into sergiym/opt/score_sign
9061c7e
bpkroth
bpkroth approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@bpkroth bpkroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment about a test and pylint protected access complaints vs. public method test. Otherwise, LGTM :)

@bpkroth bpkroth disabled auto-merge July 22, 2024 19:18
@bpkroth bpkroth merged commit 6fe46ca into microsoft:main Jul 22, 2024
11 of 12 checks passed
bpkroth added a commit to bpkroth/MLOS that referenced this pull request Jul 22, 2024
@motus @bpkroth
Fix the coercion of scores to floats in the optimizer (microsoft#789)
ca898ed 
Closes microsoft#785 

Also, add more unit tests to make sure the optimizer handles string
inputs correctly.

---------

Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
@bpkroth bpkroth mentioned this pull request Jul 24, 2024
Closed
@motus motus deleted the sergiym/opt/score_sign branch August 1, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpkroth bpkroth bpkroth approved these changes

Assignees

@motus motus

Labels
bug Something isn't working mlos-bench ready for review Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resume experiments fail when trying to bulk register previous metrics to the optimizer
2 participants
@motus @bpkroth