Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename max_iterations to max_suggestions and track in Optimizer .suggest() instead of .register() #713

Merged
merged 16 commits into from
Mar 19, 2024
Merged

Rename max_iterations to max_suggestions and track in Optimizer .suggest() instead of .register() #713

merged 16 commits into from
Mar 19, 2024

Conversation

motus
Copy link
Member

@motus motus commented Mar 15, 2024 •
edited by bpkroth
Loading

makes optimizers and schedulers a bit simpler. Part of issue #715

Closes #711

Note: the move from --max_iterations to --max_suggestions is a breaking change, so we will need to cut a new release for this.

@motus motus added WIP Work in progress - do not merge yet mlos-core labels Mar 15, 2024
@motus motus self-assigned this Mar 15, 2024
@motus motus marked this pull request as ready for review March 15, 2024 23:17
@motus motus requested a review from a team as a code owner March 15, 2024 23:17
@motus motus added ready for review Ready for review and removed WIP Work in progress - do not merge yet labels Mar 15, 2024
@motus motus enabled auto-merge (squash) March 18, 2024 23:22
@motus motus mentioned this pull request Mar 19, 2024
Merged
bpkroth
bpkroth reviewed Mar 19, 2024
View reviewed changes
mlos_bench/README.md Outdated Show resolved Hide resolved
bpkroth
bpkroth reviewed Mar 19, 2024
View reviewed changes
Copy link
Contributor

@bpkroth bpkroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments on documentation and naming I think we should address, but mostly looks good.

I'm going to update the title and description to match.

@bpkroth bpkroth changed the title Increment the iteration counter in the Optimizer .suggest() instead of .register() Rename max_iterations to max_suggestions and track in Optimizer .suggest() instead of .register() Mar 19, 2024
@motus @bpkroth
Update mlos_bench/mlos_bench/config/schemas/optimizers/optimizer-sche…
a79e119 
…ma.json

Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
bpkroth
bpkroth approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@bpkroth bpkroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor doc tweak.

@motus @bpkroth
Update mlos_bench/mlos_bench/config/schemas/optimizers/optimizer-sche…
5575718 
…ma.json

Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
@motus motus disabled auto-merge March 19, 2024 21:12
@motus motus enabled auto-merge (squash) March 19, 2024 21:30
@motus motus merged commit d2e7f05 into microsoft:main Mar 19, 2024
12 checks passed
@motus motus deleted the sergiym/opt/iter_suggest branch March 19, 2024 21:32
motus added a commit that referenced this pull request Mar 19, 2024
@motus @bpkroth
Add max_trials scheduler config parameter (#719)
f25e09f 
maybe merge after #713 (they might conflict)

Part of issue #715

---------

Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
@motus motus mentioned this pull request Mar 19, 2024
Closed
4 tasks
bpkroth added a commit to bpkroth/MLOS that referenced this pull request Aug 19, 2024
@bpkroth
Finish converting max_iterations to max_suggestions
1a285d9 
microsoft#713
@bpkroth bpkroth mentioned this pull request Aug 19, 2024
Merged
motus added a commit that referenced this pull request Aug 19, 2024
@bpkroth @motus
Finish converting max_iterations to max_suggestions (#848)
439df99 
See Also: #713

---------

Co-authored-by: Sergiy Matusevych <sergiym@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpkroth bpkroth bpkroth approved these changes

Assignees

@motus motus

Labels
mlos-bench ready for review Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increment iteration counter in .suggest() instead of .register()
2 participants
@motus @bpkroth