Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increment iteration counter in .suggest() instead of .register() #711

Closed
motus opened this issue Mar 12, 2024 · 0 comments · Fixed by #713
Closed

Increment iteration counter in .suggest() instead of .register() #711

motus opened this issue Mar 12, 2024 · 0 comments · Fixed by #713
Assignees
@motus
Labels
mlos-bench

Comments

@motus
Copy link
Member

motus commented Mar 12, 2024

That fix simplifies warming-up the optimizer and allows running multiple trials per suggestion without adjusting max_iterations parameter
@motus motus self-assigned this Mar 12, 2024
This was referenced Mar 15, 2024
Merged
Closed
@motus motus mentioned this issue Mar 15, 2024
Merged
motus added a commit that referenced this issue Mar 19, 2024
@motus @bpkroth
Rename max_iterations to max_suggestions and track in Optimizer `…
d2e7f05 
….suggest()` instead of `.register()` (#713)

makes optimizers and schedulers a bit simpler. Part of issue #715 

Closes #711 

Note: the move from `--max_iterations` to `--max_suggestions` is a
breaking change, so we will need to cut a new release for this.

---------

Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@motus motus

Labels
mlos-bench
Projects
None yet
Milestone
No milestone
1 participant
@motus