-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure One Shot Optimizer always returns the same suggestion #759
Merged
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpkroth
reviewed
Jun 28, 2024
mlos_bench/mlos_bench/config/schemas/environments/mock-env-subschema.json
Outdated
Show resolved
Hide resolved
bpkroth
reviewed
Jun 28, 2024
bpkroth
reviewed
Jun 28, 2024
bpkroth
requested changes
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's split the MockEnv changes out for clarity.
Then we can add some more tests for the new (expected) OneShot behavior in this PR.
…into sergiym/opt/one_shot
…into sergiym/opt/one_shot
Split some changes out to #769 |
…into sergiym/opt/one_shot
bpkroth
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the
OneShotOptimizer.suggest()
call always returns the same configuration.Changes related to
MockEnv
determinism moved to #769Closes #755