Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure One Shot Optimizer always returns the same suggestion #759

Merged
merged 20 commits into from
Jul 3, 2024

Conversation

motus
Copy link
Member

@motus motus commented Jun 27, 2024

Make sure the OneShotOptimizer.suggest() call always returns the same configuration.

Changes related to MockEnv determinism moved to #769

Closes #755

@motus motus self-assigned this Jun 27, 2024
@motus motus requested a review from a team as a code owner June 27, 2024 00:23
Copy link
Contributor

@bpkroth bpkroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's split the MockEnv changes out for clarity.
Then we can add some more tests for the new (expected) OneShot behavior in this PR.

@bpkroth
Copy link
Contributor

bpkroth commented Jul 1, 2024

Split some changes out to #769

@bpkroth bpkroth enabled auto-merge (squash) July 3, 2024 20:59
@bpkroth bpkroth merged commit 62d7efb into microsoft:main Jul 3, 2024
11 of 12 checks passed
@motus motus deleted the sergiym/opt/one_shot branch August 1, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mlos_bench: Benchmarking mode
2 participants