Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better naming and values for MockEnv parameters + unit tests #769

Merged
merged 14 commits into from
Jul 2, 2024
Merged

Better naming and values for MockEnv parameters + unit tests #769

merged 14 commits into from
Jul 2, 2024

Conversation

motus
Copy link
Member

@motus motus commented Jun 28, 2024

  • Use mock_env_range, mock_env_seed, and mock_env_metrics instead of just range, seed, and metrics to avoid naming conflicts.
  • Use integer mocl_env_seed values to distinguish between deterministic behavior, random seed, and user-specified seed for MockEnv.
  • Update unit tests and configs to validate the seed behavior.
  • Add new unit tests for different initializations of the tunable values

@motus motus self-assigned this Jun 28, 2024
@motus motus requested a review from a team as a code owner June 28, 2024 23:46
@motus motus mentioned this pull request Jun 28, 2024
Merged
@bpkroth bpkroth enabled auto-merge (squash) July 2, 2024 20:36
@bpkroth bpkroth merged commit 6bf3862 into microsoft:main Jul 2, 2024
12 checks passed
bpkroth added a commit that referenced this pull request Jul 3, 2024
@motus @bpkroth
Make sure One Shot Optimizer always returns the same suggestion (#759)
62d7efb 
Make sure the `OneShotOptimizer.suggest()` call always returns the same
configuration.

Changes related to `MockEnv` determinism moved to #769 

Closes #755

---------

Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
@motus motus deleted the sergiym/env/mock_env_seed branch August 1, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpkroth bpkroth bpkroth approved these changes

Assignees

@motus motus

Labels
mlos-bench ready for review Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@motus @bpkroth