Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error conversion adjustments #172

Closed
baywet opened this issue Feb 4, 2022 · 0 comments · Fixed by #174
Closed

Error conversion adjustments #172

baywet opened this issue Feb 4, 2022 · 0 comments · Fixed by #174
Assignees
@baywet
Labels
fixed type:bug A broken experience
Milestone
OData:1.0.10

Comments

@baywet
Copy link
Member

baywet commented Feb 4, 2022

  1. The main error types live under a different hardcoded namespace instead of the main one we're generating to. This makes for ugly clients and we should change that
  2. The main error type is named error, which conflicts with the native error type in typescript and Go. And because there's also a property named error on that type, it also conflicts in C#. We should change that as well.
@baywet baywet self-assigned this Feb 4, 2022
@baywet baywet added the type:bug A broken experience label Feb 4, 2022
@baywet baywet added this to the 1.0.10 milestone Feb 4, 2022
@baywet baywet mentioned this issue Feb 4, 2022
Merged
40 tasks
baywet added a commit that referenced this issue Feb 7, 2022
@baywet
- fixes #172
e3c02f2 
- moved error definitions under main namespace
- renames types to avoid conflicts with native types or naming conventions

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet baywet mentioned this issue Feb 7, 2022
Merged
@baywet baywet added the fixed label Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baywet baywet

Labels
fixed type:bug A broken experience
Projects
None yet
Milestone
OData:1.0.10
Development

Successfully merging a pull request may close this issue.

errors naming conventions improvements microsoft/OpenAPI.NET.OData
1 participant
@baywet