errors naming conventions improvements #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
baywet
commented
Feb 7, 2022
•
baywet
commented
- fixes Error conversion adjustments #172
- moved error definitions under main namespace
- renames types to avoid conflicts with native types or naming conventions
baywet
requested review from
darrelmiller,
irvinesunday and
xuzhg
as code owners
baywet
changed the title
irvinesunday
reviewed
Feb 8, 2022
src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiErrorSchemaGenerator.cs
Outdated
Show resolved
Hide resolved
40 tasks
- refactoring to avoid constants duplication Signed-off-by: Vincent Biret <vibiret@microsoft.com>
irvinesunday
reviewed
Feb 8, 2022
src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiErrorSchemaGenerator.cs
Outdated
Show resolved
Hide resolved
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
irvinesunday
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.