-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FZ Settings] Options for layout quick swap: on/off keyboard hook #10265
[FZ Settings] Options for layout quick swap: on/off keyboard hook #10265
Conversation
<value>Enable quick layout switch</value> | ||
</data> | ||
<data name="FancyZones_QuickLayoutSwitch_GroupSettings.Text" xml:space="preserve"> | ||
<value>Quick layout switch</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<value>Quick layout switch</value> | |
<value>Layout features</value> |
Suggest the text change for better flexibility on new setting in the feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@htcfreek
right now that section is specific for the quick layout switch, we should keep the description as it is.
If in the future the section will be expanded, it will be renamed.
src/settings-ui/Microsoft.PowerToys.Settings.UI.Library/ViewModels/FancyZonesViewModel.cs
Outdated
Show resolved
Hide resolved
src/settings-ui/Microsoft.PowerToys.Settings.UI.Library/ViewModels/FancyZonesViewModel.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Enrico Giordani <enricogior@users.noreply.github.com>
Summary of the Pull Request
What is this about:
Added
Quick layout switch
section in the FancyZones settings withEnable quick layout switch
andFlash zones when switching layout
CheckBoxes.The options are saved in settings as
fancyzones_quickLayoutSwitch
andfancyzones_flashZonesOnQuickSwitch
.What is include in the PR:
How does someone test / validate:
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.