Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FZ Settings] Options for layout quick swap: on/off keyboard hook #10265

Conversation

SeraphimaZykova
Copy link
Collaborator

@SeraphimaZykova SeraphimaZykova commented Mar 16, 2021

Summary of the Pull Request

What is this about:

Added Quick layout switch section in the FancyZones settings with Enable quick layout switch and Flash zones when switching layout CheckBoxes.
The options are saved in settings as fancyzones_quickLayoutSwitch and fancyzones_flashZonesOnQuickSwitch.

image

What is include in the PR:

How does someone test / validate:

Quality Checklist

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@SeraphimaZykova SeraphimaZykova added the FancyZones-Settings FancyZone setting issue label Mar 16, 2021
<value>Enable quick layout switch</value>
</data>
<data name="FancyZones_QuickLayoutSwitch_GroupSettings.Text" xml:space="preserve">
<value>Quick layout switch</value>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<value>Quick layout switch</value>
<value>Layout features</value>

Suggest the text change for better flexibility on new setting in the feature.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@htcfreek
right now that section is specific for the quick layout switch, we should keep the description as it is.
If in the future the section will be expanded, it will be renamed.

SeraphimaZykova and others added 3 commits March 17, 2021 11:47
Co-authored-by: Enrico Giordani <enricogior@users.noreply.github.com>
@SeraphimaZykova SeraphimaZykova merged commit 91aa8cc into microsoft:feature/fz-editor-layout-hotkeys Mar 17, 2021
@SeraphimaZykova SeraphimaZykova deleted the 10027-quick-swap-options branch March 17, 2021 12:39
ivan100sic pushed a commit to ivan100sic/PowerToys that referenced this pull request Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FancyZones-Settings FancyZone setting issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants