Windows snap hotkeys to move windows between screens

[vldmr11080]

Summary of the Pull Request

We currently support using WIN + ARROW key to move window through zones inside zone layout on one monitor. This pull requests improves that functionality, allowing movement to be performed in multi monitor scenario.

1. Sort monitors based on their top-left coordinate.
2. Once we reach last zone (or first, depending on direction) we switch to the layout on the different monitor and iterate through zones there.

PR Checklist

• Applies to FancyZones - Windows snap hotkeys to move windows between screens #629

[vldmr11080]

Todo: Add new unit tests which are checking modified API behavior. I've just updated current ones so they don't crash.

[enricogior]

When making changes/adding unit tests, please add @SeraphimaZ as a reviewer.

[enricogior]

With three monitors like this, where the monitor number 2 is the primary monitor

Win+right arrow moves the window from monitor 2 to monitor 1 and then to monitor 3.

These are the coordinates of the three monitors:
Monitor 1: (res 3840x2160) -719 -3840
Monitor 2: (res 3440x1440) 0 0
Monitor 3: (res 1920x1200) 241 3440

The sorting algorithm should be reversed, because it currently puts the monitor with the higher left coordinate in first position, so the current order is 3-2-1.
Also the case lhs.second.left == rhs.second.left is too specific, monitors can be one on top of the other but not aligned. So you have to always compare both X and Y and probably also the width and height to figure out the actual relative position when there are three or more monitors.
We need unit tests for this code.

[crutkas]

Will this scenario work correctly? Aero snap does it correctly. if a windows is on 3, i hit Win+LA, it will go to Monitor one. Win+RA, it will move back to 3

[vldmr11080]

Will this scenario work correctly? Aero snap does it correctly. if a windows is on 3, i hit Win+LA, it will go to Monitor one. Win+RA, it will move back to 3

This is rather basic scenario and it will work (just need to reverse my comparison function). I'm currently thinking of some more robust comparison function, for all kind of monitor number and positions.

[crutkas]

This is rather basic scenario and it will work (just need to reverse my comparison function). I'm currently thinking of some more robust comparison function, for all kind of monitor number and positions.

This shouldn't be approved then until this acts like aero snap.

We need to know the L and R virtual monitors to send window to.

[enricogior]

@crutkas
it will only be merged after it will work for scenarios up to 9 monitors and with unit tests to prove it.

[ivan100sic]

@crutkas
it will only be merged after it will work for scenarios up to 9 monitors and with unit tests to prove it.

How are we going to test private methods?

[ivan100sic]

Nevermind, I extracted the critical method (the one that should undergo tests) as a separate Util method, so we can test it. My code will take care of ordering monitors.

[enricogior]

I tested with different 3 monitor layouts, and it behaves similarly to Windows Snap.
I would be better to test it with 4 or more monitors, but let's not wait and let's merge this.