Improved monitor ordering #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vldmr11080
reviewed
Mar 23, 2020
vldmr11080
reviewed
Mar 23, 2020
|
|
||
| TEST_METHOD(TestMonitorOrdering08) | ||
| { | ||
| // AABBCC |
There was a problem hiding this comment.
Maybe we can do something like this 😃
------------------
| || || |
| || || |
------------------
| || |
| || |
------------------
vldmr11080
approved these changes
Mar 23, 2020
|
We can ask 2 more people to look at this code and then merge this first and then the main PR. |
vldmr11080
added a commit
that referenced
this pull request
Mar 25, 2020
* When moving window into zones using arrow keys, support multi-monitor scenario * Minor coding style adjustments * Split implementation into separate functions because of readability * Rename certain arguments * Modify unit tests after API changes * Address PR comments and add unit tests * Return true from MoveWindowIntoZoneByDirection only if window is successfully added to new zone * Improved monitor ordering (#1) * Implemented improved monitor ordering v1 * Fixed some embarrassing bugs, added some tests * Added one more test * Extracted a value to a variable * ASCII art in unit test comments describing monitor layouts * Removed empty line for consistency * Update comment to match the code * Refactored tests, added tests for X,Y offsets Co-authored-by: Ivan Stošić <ivan100sic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Here's my part of the code, take a look at it, then squash it and add it to your branch.
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed