Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Microsoft.Plugin.WindowWalker] Enable analyzer and fix warnings #16555

Conversation

CleanCodeDeveloper
Copy link
Contributor

Summary of the Pull Request

What is this about:

What is included in the PR:

How does someone test / validate:

Quality Checklist

  • Linked issue: Enable analyzers for each project #16511
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@CleanCodeDeveloper CleanCodeDeveloper force-pushed the fix-analyzer-warnings-in-Microsoft.Plugin.WindowWalker branch from eea2ed3 to d649232 Compare March 4, 2022 19:25
@CleanCodeDeveloper CleanCodeDeveloper marked this pull request as ready for review March 4, 2022 20:31
@htcfreek
Copy link
Collaborator

htcfreek commented Mar 4, 2022

Let's hold this one until my WindowWalker PR is merged.

cc: @jaimecbernardo , @crutkas

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution.

@jaimecbernardo jaimecbernardo merged commit 0a5bdf6 into microsoft:main Mar 8, 2022
@htcfreek
Copy link
Collaborator

htcfreek commented Mar 8, 2022

has someone validated that the changes in my pr not trigger warnings?

@CleanCodeDeveloper CleanCodeDeveloper deleted the fix-analyzer-warnings-in-Microsoft.Plugin.WindowWalker branch March 8, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants