[PTRun][WindowWalker]Fix analyzer errors

[jaimecbernardo]

Summary of the Pull Request

What is this about:
After merging #16555, #16325 added some analyzer errors, making so that main no longer builds successfully.

What is included in the PR:
Fixes for the analyzer errors.

How does someone test / validate:
CI is building again.

Quality Checklist

• Linked issue: Enable analyzers for each project #16511
• Communication: I've discussed this with core contributors in the issue.
• Tests: Added/updated and all pass
• Installer: Added/updated and all pass
• Localization: All end user facing strings can be localized
• Docs: Added/ updated
• Binaries: Any new files are added to WXS / YML
  • No new binaries
  • YML for signing for new binaries
  • WXS for installer for new binaries

[htcfreek]

@yuyoyuppe
I not sure which culture types are good to choose here. So I am interested in your opinion.

[jaimecbernardo]

@yuyoyuppe I not sure which culture types are good to choose here. So I am interested in your opinion.

I imagine this will only make a difference for desktop.ToString().ToUpper( for DesktopNames. Even so, I don't think it'll make much difference. Other uses are pretty much for english based characters.

[CleanCodeDeveloper]

I not sure which culture types are good to choose here. So I am interested in your opinion.

@htcfreek: You can have a look at the Microsoft recommendations for string usage