Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test failure when building on Linux in tmpfs due to the use of O_DIRECT #329

Open
pabs3 opened this issue Aug 1, 2022 · 1 comment
Open

test failure when building on Linux in tmpfs due to the use of O_DIRECT #329

pabs3 opened this issue Aug 1, 2022 · 1 comment

Comments

@pabs3
Copy link

pabs3 commented Aug 1, 2022

When building SPTAG on Linux in a tmpfs (a RAM-only filesystem), the tests fail because they open files with O_DIRECT but that isn't supported on tmpfs by current versions of Linux.

1: [4] Failed to create file handle: SPANN/SPTAGFullList.bin: Invalid argument
1: [4] Cannot open file:SPANN/SPTAGFullList.bin!
1: [4] Cannot Load SSDIndex!
1: ./Test/src/AlgoTest.cpp(45): error: in "AlgoTest/SPANNTest": check SPTAG::ErrorCode::Success == vecIndex->SaveIndex(out) has failed
@pabs3
Copy link
Author

pabs3 commented Aug 1, 2022

I suggest detecting when the file open failed due to missing O_DIRECT support and opening the file again without using O_DIRECT.

pabs3 added a commit to pabs3/SPTAG that referenced this issue Aug 1, 2022
@pabs3
Add support for using AsyncFileReader on filesystems without O_DIRECT…
3c7bdae 
… support.

This fixes a test failure on the Linux tmpfs filesystem.

Fixes: microsoft#329
pabs3 added a commit to pabs3/SPTAG that referenced this issue Nov 13, 2022
@pabs3
Add support for using AsyncFileReader on filesystems without O_DIRECT…
64d8a4e 
… support.

This fixes a test failure on the Linux tmpfs filesystem.

Fixes: microsoft#329
pabs3 added a commit to pabs3/SPTAG that referenced this issue Feb 5, 2023
@pabs3
Add support for using AsyncFileReader on filesystems without O_DIRECT…
e8bd4f6 
… support.

This fixes a test failure on the Linux tmpfs filesystem.

Fixes: microsoft#329
pabs3 added a commit to pabs3/SPTAG that referenced this issue Feb 5, 2023
@pabs3
Add support for using AsyncFileReader on filesystems without O_DIRECT…
36f30b7 
… support.

This fixes a test failure on the Linux tmpfs filesystem.

Fixes: microsoft#329
pabs3 added a commit to pabs3/SPTAG that referenced this issue Feb 6, 2023
@pabs3
Add support for using AsyncFileReader on filesystems without O_DIRECT…
72a8291 
… support.

This fixes a test failure on the Linux tmpfs filesystem.

Fixes: microsoft#329
pabs3 added a commit to pabs3/SPTAG that referenced this issue Mar 1, 2023
@pabs3
Add support for using AsyncFileReader on filesystems without O_DIRECT…
b2fcf6f 
… support.

This fixes a test failure on the Linux tmpfs filesystem.

Fixes: microsoft#329
pabs3 added a commit to pabs3/SPTAG that referenced this issue Mar 1, 2023
@pabs3
Add support for using AsyncFileReader on filesystems without O_DIRECT…
05ef8a7 
… support.

This fixes a test failure on the Linux tmpfs filesystem.

Fixes: microsoft#329
pabs3 added a commit to pabs3/SPTAG that referenced this issue Mar 25, 2023
@pabs3
Add support for using AsyncFileReader on filesystems without O_DIRECT…
c1f57b8 
… support.

This fixes a test failure on the Linux tmpfs filesystem.

Fixes: microsoft#329
pabs3 added a commit to pabs3/SPTAG that referenced this issue Mar 25, 2023
@pabs3
Add support for using AsyncFileReader on filesystems without O_DIRECT…
7950d27 
… support.

This fixes a test failure on the Linux tmpfs filesystem.

Fixes: microsoft#329
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
@pabs3
Add support for using AsyncFileReader on filesystems without O_DIRECT…
4807327 
… support.

This fixes a test failure on the Linux tmpfs filesystem.

Fixes: microsoft#329
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
@pabs3
Add support for using AsyncFileReader on filesystems without O_DIRECT…
f3a5dcf 
… support.

This fixes a test failure on the Linux tmpfs filesystem.

Fixes: microsoft#329
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
@pabs3
Add support for using AsyncFileReader on filesystems without O_DIRECT…
375916e 
… support.

This fixes a test failure on the Linux tmpfs filesystem.

Fixes: microsoft#329
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
@pabs3
Add support for using AsyncFileReader on filesystems without O_DIRECT…
12b5599 
… support.

This fixes a test failure on the Linux tmpfs filesystem.

Fixes: microsoft#329
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
@pabs3
Add support for using AsyncFileReader on filesystems without O_DIRECT…
6b997a0 
… support.

This fixes a test failure on the Linux tmpfs filesystem.

Fixes: microsoft#329
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
@pabs3
Add support for using AsyncFileReader on filesystems without O_DIRECT…
e58385d 
… support.

This fixes a test failure on the Linux tmpfs filesystem.

Fixes: microsoft#329
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
@pabs3
Add support for using AsyncFileReader on filesystems without O_DIRECT…
f3e3b64 
… support.

This fixes a test failure on the Linux tmpfs filesystem.

Fixes: microsoft#329
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
@pabs3
Add support for using AsyncFileReader on filesystems without O_DIRECT…
98e943e 
… support.

This fixes a test failure on the Linux tmpfs filesystem.

Fixes: microsoft#329
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
@pabs3
Add support for using AsyncFileReader on filesystems without O_DIRECT…
35736a1 
… support.

This fixes a test failure on the Linux tmpfs filesystem.

Fixes: microsoft#329
pabs3 added a commit to pabs3/SPTAG that referenced this issue May 3, 2023
@pabs3
Add support for using AsyncFileReader on filesystems without O_DIRECT…
ead3f4e 
… support.

This fixes a test failure on the Linux tmpfs filesystem.

Fixes: microsoft#329
pabs3 added a commit to pabs3/SPTAG that referenced this issue May 10, 2023
@pabs3
Add support for using AsyncFileReader on filesystems without O_DIRECT…
fac152c 
… support.

This fixes a test failure on the Linux tmpfs filesystem.

Fixes: microsoft#329
pabs3 added a commit to pabs3/SPTAG that referenced this issue Jun 16, 2023
@pabs3
Add support for using AsyncFileReader on filesystems without O_DIRECT…
c2b9ab6 
… support.

This fixes a test failure on the Linux tmpfs filesystem.

Fixes: microsoft#329
pabs3 added a commit to pabs3/SPTAG that referenced this issue Jul 20, 2023
@pabs3
Add support for using AsyncFileReader on filesystems without O_DIRECT…
f0d1b2e 
… support.

This fixes a test failure on the Linux tmpfs filesystem.

Fixes: microsoft#329
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pabs3