Clearing the way for LLVM 13 #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang 13 has new warnings to silence: * `-Wdeprecated-copy`: Warns when implicit generation of a copy constructor (respectively copy assignment operator) is deprecated due to the presence of a user-defined copy assignment operator (resp. copy constructor). * `-Wunused-but-set-variable`: Warns when a variable is only ever assigned to. (This presumably ignores class types, or at least classes with non-trivial destructors.) These changes make us nearly Clang 13-clean. There are also three known-failing libcxx tests that pass with Clang 13 since it no longer emits some false positive `-Wdangling` warnings.
fsb4000
approved these changes
Oct 9, 2021
This comment has been minimized.
This comment has been minimized.
StephanTLavavej
approved these changes
Nov 17, 2021
| @@ -57,8 +57,6 @@ struct _Monobj { // store reference to monetary amount | |||
|
|
|||
| _Money& _Val; // the monetary amount reference | |||
| bool _Intl; // international flag | |||
|
|
|||
| _Monobj& operator=(const _Monobj&) = delete; | |||
There was a problem hiding this comment.
No change requested: I vaguely recall that these were deleted because of obnoxious compiler warnings of the form "whoa, there's a reference data member, I won't be able to generate an assignment operator, and I'm going to warn about this even before you attempt to assign any objects". I believe that these warnings were fixed 🎉 and if we're not seeing them in the test suite then we're good to go.
mnatsuhara
approved these changes
Dec 7, 2021
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for preemptively fixing these warnings! 🛠️ ✔️ 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang 13 has new warnings to silence:
-Wdeprecated-copy: Warns when implicit generation of a copy constructor (respectively copy assignment operator) is deprecated due to the presence of a user-defined copy assignment operator (resp. copy constructor).-Wunused-but-set-variable: Warns when a variable is only ever assigned to. (This presumably ignores class types, or at least classes with non-trivial destructors.)These changes make us nearly Clang 13-clean. There are also three known-failing libcxx tests that pass with Clang 13 since it no longer emits some false positive
-Wdanglingwarnings. We can't change those tests from XFAIL to PASS until we update our toolset to a VS preview with Clang 13, which will probably happen in the 17.1 preview series.