Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolset update: VS 2022 17.1 Preview 2, Clang 13 #2474

Merged
merged 16 commits into from
Jan 20, 2022

Conversation

StephanTLavavej
Copy link
Member

  • Remove Clang workarounds for a -Wdangling warning that was fixed in Clang 13, as noted by @CaseyCarter in Clearing the way for LLVM 13 #2266.
  • Add EDG workaround for DevCom-1633478 / VSO-1460046 "EDG rejects hash<optional<const B>> called with optional<B>".
    • This has already been fixed, so we'll be able to remove this workaround in the near future.
  • Remove MSVC workarounds for VSO-1083296 "C++/CX conflicting with new atomic."
  • Record default settings for clang-format 13.
    • No behavioral changes.
  • clang-format all files, no manual changes.
    • The most common change is an improvement: clang-format no longer emits an extra space when calling parenthesized functions (previously it thought they looked like C-style casts). That was introduced by clang-format 12 in Toolset update: VS 2022 17.0 Preview 2 #2064.
  • Manually fix too-long lines.
    • They can usually be fixed by adding a newline (preventing = alignment). In one case I needed an empty comment // to force wrapping.
    • This should probably be reported upstream but I was a bad kitty.
  • Require MSVC 19.31 and Clang 13.
    • The internal build now uses MSVC 19.31.
  • Update node-version in update-status-chart.yml.
    • This isn't strictly necessary (I believe it always installs the latest), but is for peace of mind. This contains npm 8.3.0, which supports overrides, which we might need in the future.
  • Update README.md to mention VS 2022 17.1 Preview 2.
  • provision-image.ps1:
    • Upgrade to PowerShell 7.2.1, Python 3.10.1.
    • Print the Windows version, so we can verify whether Patch Tuesday has been picked up. This looks like: Microsoft Windows [Version 10.0.22000.434]
  • create-vmss.ps1:
    • Avoid verbose output. I finally realized that this script was emitting tons of noise because when we call an Azure PowerShell cmdlet and it returns an object, if we don't assign it to a variable, its contents are printed to the console. We can avoid this by assigning all results to variables. I named them $IgnoredType (following their documented types, verified through inspection) in case we ever want to stop ignoring them. One exception: I assigned New-AzVmss to the existing $Vmss variable (which isn't inspected after this command).
    • Fix 'Creating prototype VM' message. We should pass both -Activity and -Status like all other calls. (This was using a default "Processing" status.)
    • Use Standard_D32ads_v5. This is the latest generation SKU with temporary storage. (There's been a naming change: as_v4 had temporary storage. as_v5 doesn't, while ads_v5 does.)
  • PowerShell: Use single quotes when we don't need expansion.
  • New pool: StlBuild-2022-01-13-2
    • I ate a whole bowl of ice cream after getting this to work. 🍨

@StephanTLavavej StephanTLavavej added the infrastructure Related to repository automation label Jan 14, 2022
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner January 14, 2022 04:31
stl/inc/algorithm Show resolved Hide resolved
stl/inc/execution Show resolved Hide resolved
stl/src/tzdb.cpp Show resolved Hide resolved
@StephanTLavavej StephanTLavavej added the high priority Important! label Jan 19, 2022
@StephanTLavavej StephanTLavavej self-assigned this Jan 19, 2022
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Important! infrastructure Related to repository automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants