-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translate Async Await.ts, Optional Chaining.ts to ko #1077
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the PR! This section of the codebase is owned by @bumkeyy - if they write a comment saying "LGTM" then it will be merged. |
bumkeyy
reviewed
Sep 15, 2020
packages/playground-examples/copy/ko/JavaScript/Modern JavaScript/Async Await.ts
Outdated
Show resolved
Hide resolved
bumkeyy
reviewed
Sep 15, 2020
packages/playground-examples/copy/ko/JavaScript/Modern JavaScript/Async Await.ts
Outdated
Show resolved
Hide resolved
bumkeyy
reviewed
Sep 15, 2020
packages/playground-examples/copy/ko/JavaScript/Modern JavaScript/Async Await.ts
Outdated
Show resolved
Hide resolved
bumkeyy
reviewed
Sep 15, 2020
packages/playground-examples/copy/ko/JavaScript/Modern JavaScript/Async Await.ts
Outdated
Show resolved
Hide resolved
bumkeyy
reviewed
Sep 15, 2020
packages/playground-examples/copy/ko/JavaScript/Modern JavaScript/Async Await.ts
Outdated
Show resolved
Hide resolved
bumkeyy
reviewed
Sep 15, 2020
packages/playground-examples/copy/ko/3-7/Syntax and Messaging/Optional Chaining.ts
Outdated
Show resolved
Hide resolved
bumkeyy
reviewed
Sep 15, 2020
packages/playground-examples/copy/ko/3-7/Syntax and Messaging/Optional Chaining.ts
Outdated
Show resolved
Hide resolved
bumkeyy
reviewed
Sep 15, 2020
packages/playground-examples/copy/ko/3-7/Syntax and Messaging/Optional Chaining.ts
Outdated
Show resolved
Hide resolved
bumkeyy
reviewed
Sep 15, 2020
packages/playground-examples/copy/ko/3-7/Syntax and Messaging/Optional Chaining.ts
Outdated
Show resolved
Hide resolved
bumkeyy
reviewed
Sep 15, 2020
packages/playground-examples/copy/ko/3-7/Syntax and Messaging/Optional Chaining.ts
Outdated
Show resolved
Hide resolved
ss-won
force-pushed
the
issue910/translate-ko
branch
from
September 20, 2020 11:14
8109eda
to
e60120f
Compare
* A file was updated in packages/playground-examples/copy/ko/JavaScript/Modern JavaScript.
* A file was updated in packages/playground-examples/copy/ko/3-7/Syntax and Messaging/.
* add sections.json file to avoid test crashes * Code review first reflection
ss-won
force-pushed
the
issue910/translate-ko
branch
from
September 20, 2020 11:21
e60120f
to
b6e0e66
Compare
코드 리뷰 반영하여, 수정 완료했습니다. 🙇🏻♀️ |
LGTM |
Merging because @bumkeyy is a code-owner of all the changes - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
en:
번역 리뷰 요청합니다 : @yeonjuan @guyeol @dvlprsh
ref #910