Fixed crash when resolving a symbol on invalid private identifier in …

…type reference (#60013)
microsoft · Sep 24, 2024 · e962037 · e962037
1 parent aa9df4d
commit e962037
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -49143,15 +49143,14 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                 return resolveJSDocMemberName(name);
             }
         }
-        else if (isTypeReferenceIdentifier(name as EntityName)) {
+        else if (isEntityName(name) && isTypeReferenceIdentifier(name)) {
             const meaning = name.parent.kind === SyntaxKind.TypeReference ? SymbolFlags.Type : SymbolFlags.Namespace;
-            const symbol = resolveEntityName(name as EntityName, meaning, /*ignoreErrors*/ false, /*dontResolveAlias*/ true);
-            return symbol && symbol !== unknownSymbol ? symbol : getUnresolvedSymbolForEntityName(name as EntityName);
+            const symbol = resolveEntityName(name, meaning, /*ignoreErrors*/ false, /*dontResolveAlias*/ true);
+            return symbol && symbol !== unknownSymbol ? symbol : getUnresolvedSymbolForEntityName(name);
         }
         if (name.parent.kind === SyntaxKind.TypePredicate) {
             return resolveEntityName(name as Identifier, /*meaning*/ SymbolFlags.FunctionScopedVariable);
         }
-
         return undefined;
     }
 

diff --git a/tests/cases/fourslash/quickInfoPrivateIdentifierInTypeReferenceNoCrash1.ts b/tests/cases/fourslash/quickInfoPrivateIdentifierInTypeReferenceNoCrash1.ts
@@ -0,0 +1,13 @@
+/// <reference path="fourslash.ts" />
+
+// @target: esnext
+
+//// class Foo {
+////   #prop: string = "";
+////
+////   method() {
+////     const test: Foo.#prop/*1*/ = "";
+////   }
+//// }
+
+verify.quickInfoAt("1", "");