Fixed crash when resolving a symbol on invalid private identifier in type reference #60013

Andarist · 2024-09-20T07:55:12Z

No description provided.

…type reference

typescript-bot · 2024-09-20T07:55:16Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

jakebailey · 2024-09-24T19:31:36Z

Is there a linked issue / crash report for this?

jakebailey · 2024-09-24T19:32:01Z

@typescript-bot test it

typescript-bot · 2024-09-24T19:32:05Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

jakebailey

Seems correct to me if perf doesn't change.

typescript-bot · 2024-09-24T20:24:48Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,378	_50,378	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,772k (± 0.08%)}	_{194,476k (± 1.00%)}	_~	_192,687k	_196,318k	_{p=0.336 n=6}
_{Parse Time}	_{1.30s (± 0.79%)}	_{1.32s (± 0.42%)}	_{+0.01s (+ 0.90%)}	_1.31s	_1.32s	_{p=0.038 n=6}
_{Bind Time}	_0.71s	_{0.71s (± 0.57%)}	_~	_0.71s	_0.72s	_{p=0.405 n=6}
_{Check Time}	_{9.54s (± 0.24%)}	_{9.55s (± 0.24%)}	_~	_9.52s	_9.58s	_{p=0.570 n=6}
_{Emit Time}	_{2.71s (± 1.92%)}	_{2.71s (± 1.45%)}	_~	_2.63s	_2.74s	_{p=0.808 n=6}
_{Total Time}	_{14.27s (± 0.36%)}	_{14.29s (± 0.32%)}	_~	_14.21s	_14.35s	_{p=0.518 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,102	_947,102	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,738	_410,738	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,223,987k (± 0.00%)}	_{1,224,030k (± 0.00%)}	_~	_1,223,984k	_1,224,089k	_{p=0.128 n=6}
_{Parse Time}	_{6.61s (± 1.09%)}	_{6.63s (± 0.61%)}	_~	_6.59s	_6.70s	_{p=0.688 n=6}
_{Bind Time}	_{1.87s (± 0.81%)}	_1.87s	_~	_~	_~	_{p=0.598 n=6}
_{Check Time}	_{31.27s (± 0.26%)}	_{31.35s (± 0.36%)}	_~	_31.25s	_31.55s	_{p=0.195 n=6}
_{Emit Time}	_{15.06s (± 0.67%)}	_{15.02s (± 0.63%)}	_~	_14.83s	_15.08s	_{p=0.748 n=6}
_{Total Time}	_{54.80s (± 0.33%)}	_{54.87s (± 0.32%)}	_~	_54.68s	_55.18s	_{p=0.575 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,521,651	_2,521,651	_~	_~	_~	_{p=1.000 n=6}
_Types	_936,037	_936,037	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,351,815k (± 0.00%)}	_{2,351,857k (± 0.00%)}	_~	_2,351,809k	_2,351,984k	_{p=0.093 n=6}
_{Parse Time}	_{13.61s (± 0.29%)}	_{13.61s (± 0.26%)}	_~	_13.55s	_13.65s	_{p=0.935 n=6}
_{Bind Time}	_{3.16s (± 0.71%)}	_{3.14s (± 0.37%)}	_{-0.03s (- 0.84%)}	_3.13s	_3.16s	_{p=0.021 n=6}
_{Check Time}	_{106.18s (± 0.63%)}	_{106.25s (± 0.36%)}	_~	_105.83s	_106.89s	_{p=0.936 n=6}
_{Emit Time}	_{0.39s (± 3.24%)}	_{0.39s (± 3.24%)}	_~	_0.38s	_0.41s	_{p=1.000 n=6}
_{Total Time}	_{123.34s (± 0.56%)}	_{123.38s (± 0.32%)}	_~	_123.01s	_124.08s	_{p=0.936 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,250,019	_1,250,019	_~	_~	_~	_{p=1.000 n=6}
_Types	_264,952	_264,952	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,404,066k (± 0.03%)}	_{2,404,041k (± 0.02%)}	_~	_2,403,517k	_2,404,686k	_{p=0.575 n=6}
_{Parse Time}	_{5.15s (± 0.91%)}	_{5.14s (± 0.93%)}	_~	_5.08s	_5.20s	_{p=0.748 n=6}
_{Bind Time}	_{1.91s (± 0.51%)}	_{1.90s (± 0.27%)}	_~	_1.90s	_1.91s	_{p=0.417 n=6}
_{Check Time}	_{34.82s (± 0.11%)}	_{34.88s (± 0.13%)}	_{+0.06s (+ 0.17%)}	_34.83s	_34.94s	_{p=0.037 n=6}
_{Emit Time}	_{3.01s (± 3.31%)}	_{3.08s (± 4.35%)}	_~	_3.01s	_3.35s	_{p=0.077 n=6}
_{Total Time}	_{44.89s (± 0.40%)}	_{45.00s (± 0.22%)}	_~	_44.89s	_45.18s	_{p=0.093 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,250,019	_1,250,019	_~	_~	_~	_{p=1.000 n=6}
_Types	_264,952	_264,952	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,479,448k (± 0.02%)}	_{2,487,070k (± 0.81%)}	_~	_2,478,207k	_2,528,443k	_{p=0.230 n=6}
_{Parse Time}	_{7.89s (± 0.33%)}	_{7.92s (± 0.84%)}	_~	_7.81s	_8.01s	_{p=0.261 n=6}
_{Bind Time}	_{2.53s (± 0.60%)}	_{2.53s (± 0.79%)}	_~	_2.50s	_2.56s	_{p=0.871 n=6}
_{Check Time}	_{51.88s (± 0.83%)}	_{51.71s (± 1.05%)}	_~	_50.96s	_52.21s	_{p=0.810 n=6}
_{Emit Time}	_{4.38s (± 1.24%)}	_{4.39s (± 4.89%)}	_~	_4.12s	_4.78s	_{p=0.688 n=6}
_{Total Time}	_{66.68s (± 0.70%)}	_{66.55s (± 0.83%)}	_~	_65.57s	_67.00s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_260,921	_260,921	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,369	_106,369	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{436,546k (± 0.02%)}	_{436,537k (± 0.02%)}	_~	_436,410k	_436,725k	_{p=0.936 n=6}
_{Parse Time}	_{4.24s (± 0.49%)}	_{4.26s (± 0.43%)}	_~	_4.24s	_4.29s	_{p=0.076 n=6}
_{Bind Time}	_{1.60s (± 0.85%)}	_{1.61s (± 0.61%)}	_~	_1.60s	_1.62s	_{p=0.673 n=6}
_{Check Time}	_{22.50s (± 0.39%)}	_{22.38s (± 0.27%)}	_{-0.12s (- 0.54%)}	_22.30s	_22.47s	_{p=0.020 n=6}
_{Emit Time}	_{1.87s (± 0.40%)}	_{1.85s (± 1.73%)}	_~	_1.80s	_1.89s	_{p=0.416 n=6}
_{Total Time}	_{30.21s (± 0.31%)}	_{30.10s (± 0.26%)}	_~	_29.99s	_30.20s	_{p=0.093 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,916	_225,916	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,414	_94,414	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,927k (± 0.03%)}	_{370,921k (± 0.02%)}	_~	_370,836k	_371,047k	_{p=1.000 n=6}
_{Parse Time}	_{3.45s (± 0.97%)}	_{3.43s (± 0.82%)}	_~	_3.40s	_3.47s	_{p=0.293 n=6}
_{Bind Time}	_{1.92s (± 1.22%)}	_{1.92s (± 1.96%)}	_~	_1.88s	_1.98s	_{p=0.935 n=6}
_{Check Time}	_{19.46s (± 0.19%)}	_{19.46s (± 0.19%)}	_~	_19.42s	_19.52s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.83s (± 0.31%)}	_{24.82s (± 0.33%)}	_~	_24.72s	_24.92s	_{p=0.809 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,099,752	_3,099,752	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,068,967	_1,068,967	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,196,730k (± 0.00%)}	_{3,196,758k (± 0.00%)}	_~	_3,196,699k	_3,196,824k	_{p=0.575 n=6}
_{Parse Time}	_{13.92s (± 0.46%)}	_{13.95s (± 0.28%)}	_~	_13.89s	_13.99s	_{p=0.630 n=6}
_{Bind Time}	_{4.45s (± 2.38%)}	_{4.45s (± 2.50%)}	_~	_4.37s	_4.59s	_{p=0.807 n=6}
_{Check Time}	_{82.35s (± 0.39%)}	_{82.42s (± 0.31%)}	_~	_82.04s	_82.79s	_{p=0.810 n=6}
_{Emit Time}	_{22.38s (± 0.75%)}	_{22.41s (± 0.18%)}	_~	_22.35s	_22.45s	_{p=0.261 n=6}
_{Total Time}	_{123.11s (± 0.42%)}	_{123.22s (± 0.23%)}	_~	_122.89s	_123.68s	_{p=0.689 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_278,920	_278,920	_~	_~	_~	_{p=1.000 n=6}
_Types	_113,837	_113,837	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{428,367k (± 0.02%)}	_{428,407k (± 0.02%)}	_~	_428,288k	_428,476k	_{p=0.471 n=6}
_{Parse Time}	_{4.89s (± 0.43%)}	_{4.91s (± 0.40%)}	_~	_4.89s	_4.93s	_{p=0.067 n=6}
_{Bind Time}	_{2.12s (± 0.40%)}	_{2.12s (± 1.25%)}	_~	_2.10s	_2.17s	_{p=0.933 n=6}
_{Check Time}	_{21.78s (± 0.55%)}	_{21.82s (± 0.53%)}	_~	_21.68s	_21.98s	_{p=0.630 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.78s (± 0.41%)}	_{28.86s (± 0.52%)}	_~	_28.70s	_29.04s	_{p=0.423 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_540,027	_540,027	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,292	_181,292	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{483,545k (± 0.02%)}	_{483,546k (± 0.01%)}	_~	_483,511k	_483,618k	_{p=0.689 n=6}
_{Parse Time}	_{2.70s (± 0.56%)}	_{2.70s (± 0.49%)}	_~	_2.68s	_2.72s	_{p=0.742 n=6}
_{Bind Time}	_{0.95s (± 0.86%)}	_{0.96s (± 0.54%)}	_~	_0.95s	_0.96s	_{p=0.523 n=6}
_{Check Time}	_{15.67s (± 0.30%)}	_{15.64s (± 0.33%)}	_~	_15.56s	_15.70s	_{p=0.462 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.33s (± 0.17%)}	_{19.30s (± 0.21%)}	_~	_19.25s	_19.34s	_{p=0.332 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-09-24T20:33:09Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-09-24T20:39:28Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60013/merge:

Everything looks good!

Andarist · 2024-09-24T21:24:39Z

Is there a linked issue / crash report for this?

No, I noticed this crash in the playground's console when working on minimizing a repro for some other issue 😉

typescript-bot · 2024-09-24T21:57:56Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60013/merge:

Everything looks good!

Fixed crash when resolving a symbol on invalid private identifier in …

6f04d39

…type reference

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Sep 20, 2024

jakebailey approved these changes Sep 24, 2024

View reviewed changes

jakebailey merged commit e962037 into microsoft:main Sep 24, 2024
32 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed crash when resolving a symbol on invalid private identifier in type reference #60013

Fixed crash when resolving a symbol on invalid private identifier in type reference #60013

Andarist commented Sep 20, 2024

typescript-bot commented Sep 20, 2024

jakebailey commented Sep 24, 2024

jakebailey commented Sep 24, 2024

typescript-bot commented Sep 24, 2024 •

edited

Loading

jakebailey left a comment

typescript-bot commented Sep 24, 2024

tsc

typescript-bot commented Sep 24, 2024

typescript-bot commented Sep 24, 2024

Andarist commented Sep 24, 2024

typescript-bot commented Sep 24, 2024

Fixed crash when resolving a symbol on invalid private identifier in type reference #60013

Fixed crash when resolving a symbol on invalid private identifier in type reference #60013

Conversation

Andarist commented Sep 20, 2024

typescript-bot commented Sep 20, 2024

jakebailey commented Sep 24, 2024

jakebailey commented Sep 24, 2024

typescript-bot commented Sep 24, 2024 • edited Loading

jakebailey left a comment

Choose a reason for hiding this comment

typescript-bot commented Sep 24, 2024

tsc

typescript-bot commented Sep 24, 2024

typescript-bot commented Sep 24, 2024

Andarist commented Sep 24, 2024

typescript-bot commented Sep 24, 2024

typescript-bot commented Sep 24, 2024 •

edited

Loading