-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new node recursive file watching in tsserver #4643
Comments
Looks like it will be in node.js 4.0 and backported to IO.js 3.3.1. |
That means we can get rid of our own pollling mechanism currently in use for file watching? What about users who uses a lower node version? |
We should do feature detection. I think it is fine for new features like watching directories for new files to work on node 4 only. |
Another question is, where should we start the directory watching? If we start from the root level (e.g. "C:"), we will have to respond to a lot of system file changing events (temp file creating, other app updating their files, OneDrive syncing etc.) that is pure noise to us; if we start from the current path, we may miss when the user adds a tsconfig file in an upper level directory. |
Fixed with #5127 |
courtesy of @billti
Recursive directory watching for Windows and OSX is landing in node master: nodejs/node#2649
This enables watching a folder recursively on Windows (was already available on OS X). Under the covers this is a change in libuv (which abstracts away the OS) and uses the ‘watchSubtree’ option on the Win32 ReadDirectoryChanges function – so it should be highly reliable. (libuv change viewable here).
The text was updated successfully, but these errors were encountered: