Add directory watcher for tsserver and tsc #5127

zhengbli · 2015-10-05T23:49:19Z

This PR contains the following changes:

Unify the file / directory watcher functions in tsc and tsserver;
For inferred projects, add the ability to detect newly added tsconfig.json files in from the same directory up to the root path;
For configured projects, add the ability to detect implicitly added/removed source files (e.g., when the tsconfig.json file doesn't have a files array, and source files are added to or removed from the directory) from the same directory down recursively. (Fix server doesn't watch for file add/remove #5076, Use new node recursive file watching in tsserver #4643)
For tsconfig.json file without a files array, also added support to detect file addition / removal under tsc --watch. (Fix tsc: watch mode doesn't discover new files #4553)

Points worth notice:
Inferred projects and configured projects have different kinds of directory watchers:

For inferred projects, the sole purpose of a directory watcher is to detect newly added tsconfig.json files; and the addition normally happens from the current path up. Also, it doesn't matter which project the watcher belongs to, all inferred projects can share one set of watchers if their root files happen to be in the same folder.
For configured projects, each project has a recursive directory watcher of the path where its config file is located at. It does matter which project the watcher belongs to.
Currently the recursive watchers are supported in Node 4.0 for both OSX and Windows. If the node version is before that, the recursive watcher might not work reliably.

mhegazy · 2015-10-12T19:13:33Z

src/compiler/tsc.ts

+            }
+
+            let parsedCommandLine = configFileToParsedCommandLine(configFileName);
+            let newFileNames = parsedCommandLine.fileNames.map(compilerHost.getCanonicalFileName);


use ts.map(fileNames, ..) instead

mhegazy · 2015-10-14T23:42:35Z

src/compiler/core.ts

+    export function copyListRemovingItem<T>(item: T, list: T[]) {		
+        let copiedList: T[] = [];
+        for (var i = 0, len = list.length; i < len; i++) {
+            if (list[i] != item) {


mhegazy · 2015-10-15T00:35:11Z

src/server/editorServices.ts

+                    if (!(--project.projectService.directoryWatchersRefCount[directory])) {
+                        this.log("Close directory watcher for: " + directory);
+                        project.projectService.directoryWatchersForTsconfig[directory].close();
+                        project.projectService.directoryWatchersForTsconfig[directory] = undefined;


possibly use delete

mhegazy · 2015-10-15T00:36:55Z

👍

Add directory watcher for tsserver and tsc

vladima · 2015-10-15T02:16:36Z

src/compiler/core.ts

+
+    export function copyListRemovingItem<T>(item: T, list: T[]) {
+        let copiedList: T[] = [];
+        for (var i = 0, len = list.length; i < len; i++) {


use for-of

vladima · 2015-10-15T02:41:11Z

pinging @zhengbli, there are few comments, can you please address them (sorry for the delay)/

zhengbli · 2015-10-15T04:41:43Z

@vladima The code review is addresses at #5263.

jbrantly · 2015-10-17T00:20:15Z

This included a breaking API change by renaming parseConfigFile to parseJsonConfigFileContent and parseConfigFileText to parseConfigFileTextToJson

Random aside but a new function copyListRemovingItem is also being exported. Seems like an internal utility function to me but shrug

Address code review of #5127

microsoft/TypeScript#5127 microsoft/TypeScript#5310 Closes #6

zhengbli added 10 commits October 1, 2015 15:25

Change fileWatcher in sys for node 4

0bc5c14

unify the node filewatcher in sys.ts and server.ts

5daa100

bug fixes

4dcf8c7

temp save

98eaeba

Redesigned directory watchers

7fa26ad

Add directory watcher to tsc

9db53f2

Use fs.watch for all directory watchers and some bug fixes

7741ec0

Update comments

17f0cce

Incorporating changes from microsoft#3780

f7e35d5

Merge branch Microsoft/master

3b6f283

msftclas added the cla-not-required label Oct 5, 2015

zhengbli added 2 commits October 6, 2015 12:33

Lint fixes and test fixes

8171ded

more test fixes

9ed5b4c

mhegazy reviewed Oct 12, 2015
View reviewed changes

zhengbli added 3 commits October 14, 2015 15:10

CR feedback

002f0c0

Fix issues with removing roots

def268c

Add timer for batch processing directory changes

62664fd

zhengbli added 2 commits October 14, 2015 16:25

Address build errors

6013968

Fix rwcRunner

c754999

mhegazy reviewed Oct 14, 2015
View reviewed changes

Fix lint errors

fcfc25e

mhegazy reviewed Oct 15, 2015
View reviewed changes

zhengbli added a commit that referenced this pull request Oct 15, 2015

Merge pull request #5127 from zhengbli/newAddDirectoryWatcher

8864b06

Add directory watcher for tsserver and tsc

zhengbli merged commit 8864b06 into microsoft:master Oct 15, 2015

zhengbli mentioned this pull request Oct 15, 2015

Use new node recursive file watching in tsserver #4643

Closed

vladima reviewed Oct 15, 2015
View reviewed changes

zhengbli mentioned this pull request Oct 15, 2015

Address code review of #5127 #5263

Merged

jbrantly mentioned this pull request Oct 17, 2015

Nightly is currently failing due to parseConfigFile API change TypeStrong/ts-loader#83

Closed

zhengbli added a commit that referenced this pull request Oct 20, 2015

Merge pull request #5263 from zhengbli/pr5127cr

1b36407

Address code review of #5127

mhegazy modified the milestones: TypeScript 1.7.3, TypeScript 1.7 Oct 27, 2015

mhegazy added the Breaking Change Would introduce errors in existing code label Oct 27, 2015

chancancode added a commit to tildeio/broccoli-typescript-compiler that referenced this pull request Nov 4, 2015

Support TypeScript 1.8+

989c0fc

microsoft/TypeScript#5127 microsoft/TypeScript#5310 Closes #6

microsoft locked and limited conversation to collaborators Jun 19, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add directory watcher for tsserver and tsc #5127

Add directory watcher for tsserver and tsc #5127

zhengbli commented Oct 5, 2015

mhegazy Oct 12, 2015

mhegazy Oct 14, 2015

mhegazy Oct 15, 2015

mhegazy commented Oct 15, 2015

vladima Oct 15, 2015

vladima commented Oct 15, 2015

zhengbli commented Oct 15, 2015

jbrantly commented Oct 17, 2015

Add directory watcher for tsserver and tsc #5127

Add directory watcher for tsserver and tsc #5127

Conversation

zhengbli commented Oct 5, 2015

mhegazy Oct 12, 2015

Choose a reason for hiding this comment

mhegazy Oct 14, 2015

Choose a reason for hiding this comment

mhegazy Oct 15, 2015

Choose a reason for hiding this comment

mhegazy commented Oct 15, 2015

vladima Oct 15, 2015

Choose a reason for hiding this comment

vladima commented Oct 15, 2015

zhengbli commented Oct 15, 2015

jbrantly commented Oct 17, 2015