Add directory watcher in inferred projects #4468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengbli
force-pushed
the
addTsconfigDirWatcher
branch
from
e8ca5f1 to
ed931d4
Compare
| @@ -569,6 +609,21 @@ namespace ts.server { | |||
| createInferredProject(root: ScriptInfo) { | |||
| var iproj = new Project(this); | |||
There was a problem hiding this comment.
nit: can you rename this to a more readable "inferredProject" or just "project"
|
as we talked offline, closing this in favor of a PR addressing #4643 instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added directory watchers in inferred projects to detect the addition of tsconfig.json in the future. This fixes the workaround for issue #3244.