Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In checkAndAggregateReturnExpressionTypes, treat MethodDeclaration in an object literal same as a FunctionExpression #20052

Merged
2 commits merged into from
Jan 5, 2018

Conversation

ghost
Copy link

@ghost ghost commented Nov 15, 2017

… an object literal same as a FunctionExpression
@ghost ghost requested review from sandersn and RyanCavanaugh November 16, 2017 17:04
@ghost
Copy link
Author

ghost commented Dec 6, 2017

@sandersn @RyanCavanaugh Please review

@RyanCavanaugh
Copy link
Member

Please include the repro as a testcase

@ghost
Copy link
Author

ghost commented Dec 6, 2017

@RyanCavanaugh Good to go?

@ghost ghost merged commit c6e4373 into master Jan 5, 2018
@ghost ghost deleted the methoddecl branch January 5, 2018 20:34
errendir added a commit to errendir/TypeScript that referenced this pull request Jan 7, 2018
* origin/master: (61 commits)
  Add release-2.7 to covered branches
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  API: fix types to undefined union (microsoft#20909)
  Fix conflict between formatting rules (microsoft#21038)
  Switch to block-bodied lambda
  Better name for deferred mapped type:ReverseMapped
  Slightly simplify getCodeActions
  Make fixCannotFindModule return an empty array if there is no code action
  In checkAndAggregateReturnExpressionTypes, treat MethodDeclaration in an object literal same as a FunctionExpression (microsoft#20052)
  Return string completions for indexed access types
  Check for unused getter/setter in classes (microsoft#21013)
  Only replace `implements` with a comma if the heritage clauses are sensible
  Refine extends-to-implements code fix
  Fix version of @types/node to 8.5.5 (microsoft#21019)
  fix microsoft#20449, insert space between decorators (microsoft#20491)
  findConfigFile can return undefined (microsoft#20556)
  Allowed trailing commas in type parameter/argument lists (microsoft#20599)
  Added localization instructions to CONTRIBUTING.md (microsoft#20451)
  Simplify marker names
  ...
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant