Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added localization instructions to CONTRIBUTING.md #20451

Merged
merged 3 commits into from
Jan 5, 2018

Conversation

JoshuaKGoldberg
Copy link
Contributor

Fixes #20418

CONTRIBUTING.md Outdated
## Localization

All strings the user may see are stored in [`diagnosticMessages.json`](./src/compiler/diagnosticMessages.json).
If you make changes to it, run `jake generate-diagnostics` to push them to the generated localization and definition files.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i do not think the last line is accurate.. jake generate-diagnostics just generates a .ts file that .src\compiler\diagnosticInformationMap.generated.ts that makes the diagnostic messages properties on the Diagnostics, with property names generated from their text.

@mhegazy
Copy link
Contributor

mhegazy commented Dec 4, 2017

I would also add a link to the details in https://github.com/Microsoft/TypeScript/wiki/Coding-guidelines#diagnostic-messages

@mhegazy mhegazy merged commit 85b32ed into microsoft:master Jan 5, 2018
@JoshuaKGoldberg JoshuaKGoldberg deleted the patch-1 branch January 6, 2018 02:00
errendir added a commit to errendir/TypeScript that referenced this pull request Jan 7, 2018
* origin/master: (61 commits)
  Add release-2.7 to covered branches
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  API: fix types to undefined union (microsoft#20909)
  Fix conflict between formatting rules (microsoft#21038)
  Switch to block-bodied lambda
  Better name for deferred mapped type:ReverseMapped
  Slightly simplify getCodeActions
  Make fixCannotFindModule return an empty array if there is no code action
  In checkAndAggregateReturnExpressionTypes, treat MethodDeclaration in an object literal same as a FunctionExpression (microsoft#20052)
  Return string completions for indexed access types
  Check for unused getter/setter in classes (microsoft#21013)
  Only replace `implements` with a comma if the heritage clauses are sensible
  Refine extends-to-implements code fix
  Fix version of @types/node to 8.5.5 (microsoft#21019)
  fix microsoft#20449, insert space between decorators (microsoft#20491)
  findConfigFile can return undefined (microsoft#20556)
  Allowed trailing commas in type parameter/argument lists (microsoft#20599)
  Added localization instructions to CONTRIBUTING.md (microsoft#20451)
  Simplify marker names
  ...
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants