Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document process for adding new localized strings #20418

Closed
JoshuaKGoldberg opened this issue Dec 3, 2017 · 2 comments
Closed

Document process for adding new localized strings #20418

JoshuaKGoldberg opened this issue Dec 3, 2017 · 2 comments
Labels
Question An issue which isn't directly actionable in code

Comments

@JoshuaKGoldberg
Copy link
Contributor

Scenario: You'd like to add a new diagnostic message in the CLI, and don't know where to start.

From existing pull requests, it looks like it's as simple as adding an entry in diagnosticMessages.json.

  • Is that is?
  • What part(s) of the build process interact with that?
  • What are the guidelines for doing so?
  • How do those strings become localized (are pull requests or features blocked on external localization teams, and if so how long is the ETA for localization)?
@mhegazy
Copy link
Contributor

mhegazy commented Dec 4, 2017

Add the message to https://github.com/Microsoft/TypeScript/blob/master/src/compiler/diagnosticMessages.json, run jake generate-diagnostics and use the name of the generated message, that is it.

We have a script that will send the new strings added nightly to our loc team, and they will merge in the new localized strings independently. the time depends on multiple factors, but usually within a week or two the string should be localized in all languages. but you do not need to worry about this, I can take care of that. If a message is not localized in a specific language, the text will show in English.

@mhegazy mhegazy added the Question An issue which isn't directly actionable in code label Dec 4, 2017
JoshuaKGoldberg pushed a commit to JoshuaKGoldberg/TypeScript that referenced this issue Dec 4, 2017
@typescript-bot
Copy link
Collaborator

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.

mhegazy pushed a commit that referenced this issue Jan 5, 2018
* Added localization instructions to CONTRIBUTING.md

Fixes #20418

* Corrected mention of generated ts file

* Mentioned coding guidelines
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Question An issue which isn't directly actionable in code
Projects
None yet
Development

No branches or pull requests

3 participants