Skip to content

Commit

Permalink
Added localization instructions to CONTRIBUTING.md (#20451)
Browse files Browse the repository at this point in the history
* Added localization instructions to CONTRIBUTING.md

Fixes #20418

* Corrected mention of generated ts file

* Mentioned coding guidelines
  • Loading branch information
Josh Goldberg authored and mhegazy committed Jan 5, 2018
1 parent 5865494 commit 85b32ed
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -183,3 +183,10 @@ jake baseline-accept
```

to establish the new baselines as the desired behavior. This will change the files in `tests\baselines\reference`, which should be included as part of your commit. It's important to carefully validate changes in the baselines.

## Localization

All strings the user may see are stored in [`diagnosticMessages.json`](./src/compiler/diagnosticMessages.json).
If you make changes to it, run `jake generate-diagnostics` to push them to the `Diagnostic` interface in [`diagnosticInformationMap.generated.ts`](./src/compiler/diagnosticInformationMap.generated.ts).

See [coding guidelines on diagnostic messages](https://github.com/Microsoft/TypeScript/wiki/Coding-guidelines#diagnostic-messages).

0 comments on commit 85b32ed

Please sign in to comment.