update generated diagnostic messages for isolated declarations #59562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
jakebailey
reviewed
Aug 8, 2024
| result.push("};"); | ||
|
|
||
| return result.join("\r\n"); | ||
| return result.join("\r\n") + interfaceResult.join("\r\n"); |
There was a problem hiding this comment.
Can you put the interface first? It doesn't matter in practice, but seems better to declare the type before using it.
jakebailey
reviewed
Aug 8, 2024
| ]; | ||
| const interfaceResult = ["\r\ninterface Diagnostics {"]; |
There was a problem hiding this comment.
This will have to be exported / internal.
|
The duplication is unfortunate; I do wonder if there's a better way but I think this is the minimally invasive way. The only other thing I can think of is like: export const Diagnostics = {
Foo: diag() as Diagnostic,
}But not sure if ID accepts that. |
|
closed in #59635 (did it there) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In investigating adopting isolated declarations (#59097), I found that the generated
Diagnosticsneeds a type annotation. This updates the script so we're able to provide a type annotation for it.(this PR does not turn on the flag but once I make the PR that turns on the flag, I'll link it here: ____)