Enable `--isolatedDeclarations` on TS codebase #59635

iisaduan · 2024-08-14T21:13:17Z

fixes #59097 : enables --isolatedDeclarations on our codebase

…sticMessages

typescript-bot · 2024-08-14T21:13:29Z

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

iisaduan

These are the generator types: for 5.5, I had to use any in these cases since unknown is not assignable to undefined (and the inferred TNext type in these cases is undefined

src/compiler/core.ts

src/harness/collectionsImpl.ts

src/compiler/core.ts

iisaduan

Here are updates to as const objects (and other related kinds of objects)

and this #59635 (comment)

src/harness/vfsUtil.ts

src/compiler/types.ts

src/compiler/utilitiesPublic.ts

scripts/processDiagnosticMessages.mjs

src/compiler/types.ts

src/compiler/builder.ts

src/compiler/debug.ts

jakebailey

Pretty hard to review the whole thing because the diff is so big, but I do wonder if we should even bother doing this for harness/testRunner given those don't actually have a public API...

In general though I do think we should try and name some of the types introduced here. That and there are some really unfortunate losses of inference here :(

src/compiler/expressionToTypeNode.ts

src/compiler/moduleNameResolver.ts

src/compiler/sourcemap.ts

src/compiler/sys.ts

src/compiler/transformers/declarations.ts

src/compiler/types.ts

src/compiler/utilities.ts

src/server/editorServices.ts

iisaduan

these are the places where any shows up (not counting workarounds for generators). there could be better ways to type them.

src/compiler/utilities.ts

src/harness/evaluatorImpl.ts

src/server/session.ts

iisaduan · 2024-08-20T18:30:08Z

@typescript-bot perf test this faster

iisaduan · 2024-09-13T01:26:16Z

@typescript-bot perf test this faster

typescript-bot · 2024-09-13T01:26:19Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this faster`	✅ Started	👀 Results

src/compiler/builder.ts

typescript-bot · 2024-09-13T02:06:43Z

@iisaduan
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,618k (± 0.98%)}	_{193,675k (± 0.92%)}	_~	_192,412k	_196,002k	_{p=0.298 n=6}
_{Parse Time}	_{1.30s (± 0.64%)}	_{1.30s (± 1.57%)}	_~	_1.27s	_1.33s	_{p=0.797 n=6}
_{Bind Time}	_0.71s	_0.71s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.54s (± 0.41%)}	_{9.55s (± 0.38%)}	_~	_9.49s	_9.59s	_{p=0.573 n=6}
_{Emit Time}	_{2.71s (± 0.66%)}	_{2.71s (± 1.97%)}	_~	_2.61s	_2.76s	_{p=0.371 n=6}
_{Total Time}	_{14.27s (± 0.29%)}	_{14.28s (± 0.49%)}	_~	_14.15s	_14.34s	_{p=0.520 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,753	_945,753	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,067	_410,067	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,749k (± 0.00%)}	_{1,222,727k (± 0.00%)}	_~	_1,222,642k	_1,222,798k	_{p=0.298 n=6}
_{Parse Time}	_{6.66s (± 0.30%)}	_{6.65s (± 0.70%)}	_~	_6.59s	_6.73s	_{p=0.625 n=6}
_{Bind Time}	_{1.86s (± 0.22%)}	_{1.86s (± 0.40%)}	_~	_1.85s	_1.87s	_{p=0.389 n=6}
_{Check Time}	_{31.20s (± 0.33%)}	_{31.27s (± 0.25%)}	_~	_31.16s	_31.34s	_{p=0.296 n=6}
_{Emit Time}	_{15.10s (± 0.47%)}	_{15.06s (± 0.15%)}	_~	_15.02s	_15.08s	_{p=0.517 n=6}
_{Total Time}	_{54.81s (± 0.29%)}	_{54.84s (± 0.18%)}	_~	_54.73s	_54.99s	_{p=0.687 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,529,234	_2,529,234	_~	_~	_~	_{p=1.000 n=6}
_Types	_935,840	_935,840	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,364,190k (± 0.00%)}	_{2,364,164k (± 0.00%)}	_{-26k (- 0.00%)}	_2,364,126k	_2,364,184k	_{p=0.031 n=6}
_{Parse Time}	_{9.42s (± 0.42%)}	_{9.40s (± 0.26%)}	_~	_9.37s	_9.42s	_{p=0.225 n=6}
_{Bind Time}	_{2.17s (± 0.63%)}	_{2.18s (± 0.65%)}	_~	_2.16s	_2.20s	_{p=0.623 n=6}
_{Check Time}	_{73.39s (± 0.46%)}	_{73.05s (± 0.47%)}	_~	_72.63s	_73.60s	_{p=0.093 n=6}
_{Emit Time}	_{0.28s (± 3.49%)}	_{0.28s (± 1.45%)}	_~	_0.28s	_0.29s	_{p=0.753 n=6}
_{Total Time}	_{85.26s (± 0.41%)}	_{84.91s (± 0.40%)}	_~	_84.51s	_85.44s	_{p=0.093 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,250,418	_1,247,568	_{-2,850 (- 0.23%)}	_~	_~	_{p=0.001 n=6}
_Types	_265,229	_264,308	_{-921 (- 0.35%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,402,888k (± 0.01%)}	_{2,399,829k (± 0.02%)}	_{-3,059k (- 0.13%)}	_2,398,957k	_2,400,333k	_{p=0.005 n=6}
_{Parse Time}	_{5.11s (± 1.12%)}	_{5.06s (± 0.55%)}	_~	_5.02s	_5.09s	_{p=0.149 n=6}
_{Bind Time}	_{1.90s (± 0.61%)}	_{1.91s (± 0.43%)}	_~	_1.90s	_1.92s	_{p=0.401 n=6}
_{Check Time}	_{34.88s (± 0.39%)}	_{34.77s (± 0.18%)}	_~	_34.67s	_34.83s	_{p=0.230 n=6}
_{Emit Time}	_{3.32s (± 1.41%)}	_{3.03s (± 3.37%)}	_{🟩-0.29s (- 8.59%)}	_2.93s	_3.21s	_{p=0.005 n=6}
_{Total Time}	_{45.21s (± 0.21%)}	_{44.79s (± 0.20%)}	_{-0.42s (- 0.94%)}	_44.68s	_44.93s	_{p=0.005 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,250,418	_1,247,568	_{-2,850 (- 0.23%)}	_~	_~	_{p=0.001 n=6}
_Types	_265,229	_264,308	_{-921 (- 0.35%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,477,458k (± 0.03%)}	_{2,474,443k (± 0.03%)}	_{-3,015k (- 0.12%)}	_2,473,585k	_2,475,438k	_{p=0.005 n=6}
_{Parse Time}	_{6.31s (± 1.05%)}	_{6.32s (± 0.43%)}	_~	_6.29s	_6.35s	_{p=0.375 n=6}
_{Bind Time}	_{2.04s (± 0.72%)}	_{2.05s (± 0.40%)}	_~	_2.04s	_2.06s	_{p=0.254 n=6}
_{Check Time}	_{41.39s (± 1.00%)}	_{41.71s (± 0.75%)}	_~	_41.26s	_42.03s	_{p=0.148 n=6}
_{Emit Time}	_{4.02s (± 2.19%)}	_{3.57s (± 1.36%)}	_{🟩-0.45s (-11.23%)}	_3.50s	_3.61s	_{p=0.005 n=6}
_{Total Time}	_{53.78s (± 0.71%)}	_{53.67s (± 0.59%)}	_~	_53.19s	_53.99s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_259,449	_259,700	_{+251 (+ 0.10%)}	_~	_~	_{p=0.001 n=6}
_Types	_105,986	_106,182	_{+196 (+ 0.18%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{433,875k (± 0.01%)}	_{435,718k (± 0.03%)}	_{+1,843k (+ 0.42%)}	_435,569k	_435,892k	_{p=0.005 n=6}
_{Parse Time}	_{3.44s (± 0.85%)}	_{3.43s (± 0.44%)}	_~	_3.40s	_3.44s	_{p=0.506 n=6}
_{Bind Time}	_{1.28s (± 0.32%)}	_{1.30s (± 0.31%)}	_{+0.02s (+ 1.30%)}	_1.29s	_1.30s	_{p=0.003 n=6}
_{Check Time}	_{18.12s (± 0.51%)}	_{18.13s (± 0.40%)}	_~	_18.03s	_18.20s	_{p=0.808 n=6}
_{Emit Time}	_{1.65s (± 1.31%)}	_{1.53s (± 1.67%)}	_{🟩-0.12s (- 7.19%)}	_1.51s	_1.57s	_{p=0.005 n=6}
_{Total Time}	_{24.48s (± 0.44%)}	_{24.39s (± 0.35%)}	_~	_24.27s	_24.51s	_{p=0.199 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,249	_94,249	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,227k (± 0.02%)}	_{370,217k (± 0.02%)}	_~	_370,122k	_370,291k	_{p=0.936 n=6}
_{Parse Time}	_{2.77s (± 0.59%)}	_{2.77s (± 0.99%)}	_~	_2.73s	_2.81s	_{p=0.871 n=6}
_{Bind Time}	_{1.57s (± 0.52%)}	_{1.57s (± 0.63%)}	_~	_1.55s	_1.58s	_{p=0.604 n=6}
_{Check Time}	_{15.76s (± 0.32%)}	_{15.74s (± 0.14%)}	_~	_15.71s	_15.77s	_{p=0.628 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.10s (± 0.25%)}	_{20.09s (± 0.23%)}	_~	_20.01s	_20.13s	_{p=0.809 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,059,799	_3,059,799	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,057,277	_1,057,277	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,166,989k (± 0.00%)}	_{3,166,958k (± 0.00%)}	_~	_3,166,891k	_3,167,002k	_{p=0.298 n=6}
_{Parse Time}	_{13.91s (± 0.25%)}	_{13.91s (± 0.43%)}	_~	_13.85s	_14.02s	_{p=0.469 n=6}
_{Bind Time}	_{4.35s (± 0.45%)}	_{4.34s (± 0.32%)}	_~	_4.33s	_4.36s	_{p=1.000 n=6}
_{Check Time}	_{81.76s (± 0.40%)}	_{81.77s (± 0.25%)}	_~	_81.37s	_81.94s	_{p=1.000 n=6}
_{Emit Time}	_{22.19s (± 0.37%)}	_{22.23s (± 0.61%)}	_~	_22.04s	_22.43s	_{p=0.521 n=6}
_{Total Time}	_{122.20s (± 0.24%)}	_{122.25s (± 0.21%)}	_~	_121.81s	_122.50s	_{p=0.873 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_277,156	_277,156	_~	_~	_~	_{p=1.000 n=6}
_Types	_112,946	_112,946	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{426,970k (± 0.02%)}	_{427,020k (± 0.02%)}	_~	_426,934k	_427,156k	_{p=0.471 n=6}
_{Parse Time}	_{4.90s (± 0.44%)}	_{4.90s (± 0.45%)}	_~	_4.87s	_4.93s	_{p=0.870 n=6}
_{Bind Time}	_{2.15s (± 0.70%)}	_{2.13s (± 0.81%)}	_~	_2.10s	_2.15s	_{p=0.210 n=6}
_{Check Time}	_{21.80s (± 0.43%)}	_{21.81s (± 0.23%)}	_~	_21.73s	_21.85s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.85s (± 0.37%)}	_{28.84s (± 0.21%)}	_~	_28.76s	_28.92s	_{p=0.872 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_539,317	_539,317	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,997	_178,997	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{484,151k (± 0.02%)}	_{484,230k (± 0.04%)}	_~	_483,968k	_484,507k	_{p=0.471 n=6}
_{Parse Time}	_{3.42s (± 0.40%)}	_{3.38s (± 0.39%)}	_{-0.04s (- 1.12%)}	_3.36s	_3.39s	_{p=0.005 n=6}
_{Bind Time}	_{1.25s (± 0.71%)}	_{1.26s (± 0.32%)}	_~	_1.25s	_1.26s	_{p=0.086 n=6}
_{Check Time}	_{18.30s (± 0.45%)}	_{18.31s (± 0.27%)}	_~	_18.22s	_18.36s	_{p=0.936 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.97s (± 0.36%)}	_{22.94s (± 0.26%)}	_~	_22.84s	_23.01s	_{p=0.629 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

src/compiler/moduleNameResolver.ts

src/compiler/scanner.ts

src/compiler/transformers/declarations.ts

src/compiler/types.ts

src/services/exportInfoMap.ts

src/compiler/utilities.ts

Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>

src/compiler/program.ts

src/compiler/sys.ts

src/compiler/commandLineParser.ts

jakebailey · 2024-09-14T03:23:41Z

src/compiler/types.ts

@@ -10189,7 +10224,78 @@ export type PragmaArgumentType<KPrag extends keyof ConcretePragmaSpecs> = Concre
    : never;

 /** @internal */
-export type ConcretePragmaSpecs = typeof commentPragmas;
+export interface ConcretePragmaSpecs {
+    readonly "reference": {


Still wish we could do something simpler here, but we also don't really touch this that much. (I'm personally okay with it becoming a little less safe just to not have this duplication)

src/server/editorServices.ts

Zzzen · 2024-09-23T04:02:41Z

Does isolated declarations improve the performance of the language service?

iisaduan · 2024-10-01T17:23:13Z

@Zzzen this PR shouldn't have any performance effect on our implementation of the language service. It's possible enabling it in your own code could make some parts of the LS faster in your projects, but we have not benchmarked anything or made ID specific performance improvements for the LS.

iisaduan added 16 commits August 5, 2024 15:02

turn on compiler flag

3ddb26a

mostly generated by quickfixes (some formatting)

49676b5

update generate diagnostic messages script to provide type for Diagno…

6e50be8

…sticMessages

update ScriptTarget and LanguageFeatureMinimumTarget enums

6a6c1f9

generated codefixes on services

6c6c89a

generated codefixes on server

7567038

generated codefixes harness

4c1bc99

lint

5c13c8d

update generateDiagnosticMessages script for eslint

4e5524b

generated codefixes harness 2

0bd2108

generated codefixes testrunner

eeb6165

update baselines

58a7fcf

remove extra generated ts.

326123f

make commentpragma type

303d726

update baselines

7d3ccb3

add as const and reduce duplications

b89abd1

typescript-bot assigned iisaduan Aug 14, 2024

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Aug 14, 2024

iisaduan commented Aug 14, 2024

View reviewed changes

rbuckton requested changes Aug 14, 2024

View reviewed changes

src/compiler/core.ts Show resolved Hide resolved

src/compiler/core.ts Outdated Show resolved Hide resolved

iisaduan commented Aug 14, 2024

View reviewed changes

weswigham reviewed Aug 14, 2024

View reviewed changes

src/compiler/types.ts Show resolved Hide resolved

jakebailey reviewed Aug 14, 2024

View reviewed changes

src/compiler/builder.ts Outdated Show resolved Hide resolved

jakebailey reviewed Aug 14, 2024

View reviewed changes

src/compiler/debug.ts Outdated Show resolved Hide resolved

DanielRosenwasser changed the title ~~turn on --isolated declarations~~ Enable --isolatedDeclarations on TS codebase Aug 14, 2024

jakebailey reviewed Aug 14, 2024

View reviewed changes

iisaduan commented Aug 15, 2024

View reviewed changes

src/compiler/utilities.ts Show resolved Hide resolved

src/harness/evaluatorImpl.ts Show resolved Hide resolved

src/harness/evaluatorImpl.ts Show resolved Hide resolved

src/server/session.ts Show resolved Hide resolved

iisaduan requested review from jakebailey, weswigham, DanielRosenwasser and andrewbranch September 13, 2024 01:25

jakebailey reviewed Sep 13, 2024

View reviewed changes

src/compiler/builder.ts Outdated Show resolved Hide resolved

jakebailey reviewed Sep 13, 2024

View reviewed changes

src/compiler/moduleNameResolver.ts Outdated Show resolved Hide resolved

jakebailey reviewed Sep 13, 2024

View reviewed changes

src/compiler/scanner.ts Outdated Show resolved Hide resolved

jakebailey reviewed Sep 13, 2024

View reviewed changes

src/compiler/transformers/declarations.ts Outdated Show resolved Hide resolved

jakebailey reviewed Sep 13, 2024

View reviewed changes

src/compiler/types.ts Outdated Show resolved Hide resolved

jakebailey reviewed Sep 13, 2024

View reviewed changes

src/compiler/types.ts Show resolved Hide resolved

src/compiler/types.ts Outdated Show resolved Hide resolved

src/services/exportInfoMap.ts Outdated Show resolved Hide resolved

src/compiler/utilities.ts Outdated Show resolved Hide resolved

iisaduan and others added 3 commits September 12, 2024 23:06

address comments, remove extra lines

de60e62

use languageFeatures index

27bede6

Update src/testRunner/unittests/helpers/contents.ts with options object

f498dcb

Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>

sheetalkamat reviewed Sep 13, 2024

View reviewed changes

src/compiler/program.ts Outdated Show resolved Hide resolved

sheetalkamat reviewed Sep 13, 2024

View reviewed changes

src/compiler/program.ts Outdated Show resolved Hide resolved

sheetalkamat reviewed Sep 13, 2024

View reviewed changes

src/compiler/sys.ts Outdated Show resolved Hide resolved

Simplify computed options

1c559c4

jakebailey reviewed Sep 13, 2024

View reviewed changes

src/compiler/commandLineParser.ts Outdated Show resolved Hide resolved

iisaduan added 2 commits September 13, 2024 13:57

remove eslint rule

6296b14

comments

bea7205

rbuckton approved these changes Sep 13, 2024

View reviewed changes

jakebailey approved these changes Sep 14, 2024

View reviewed changes

iisaduan merged commit 52eaa7b into microsoft:main Sep 16, 2024
30 checks passed

iisaduan deleted the addIsolatedDecl branch September 16, 2024 21:01

iisaduan mentioned this pull request Sep 30, 2024

update generated diagnostic messages for isolated declarations #59562

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable `--isolatedDeclarations` on TS codebase #59635

Enable `--isolatedDeclarations` on TS codebase #59635

iisaduan commented Aug 14, 2024 •

edited

Loading

typescript-bot commented Aug 14, 2024

iisaduan left a comment •

edited

Loading

iisaduan left a comment •

edited

Loading

jakebailey left a comment

iisaduan left a comment

iisaduan commented Aug 20, 2024

iisaduan commented Sep 13, 2024

typescript-bot commented Sep 13, 2024 •

edited

Loading

typescript-bot commented Sep 13, 2024

tsc

jakebailey Sep 14, 2024

Zzzen commented Sep 23, 2024

iisaduan commented Oct 1, 2024 •

edited

Loading

Enable --isolatedDeclarations on TS codebase #59635

Enable --isolatedDeclarations on TS codebase #59635

Conversation

iisaduan commented Aug 14, 2024 • edited Loading

typescript-bot commented Aug 14, 2024

iisaduan left a comment • edited Loading

Choose a reason for hiding this comment

iisaduan left a comment • edited Loading

Choose a reason for hiding this comment

jakebailey left a comment

Choose a reason for hiding this comment

iisaduan left a comment

Choose a reason for hiding this comment

iisaduan commented Aug 20, 2024

iisaduan commented Sep 13, 2024

typescript-bot commented Sep 13, 2024 • edited Loading

typescript-bot commented Sep 13, 2024

tsc

jakebailey Sep 14, 2024

Choose a reason for hiding this comment

Zzzen commented Sep 23, 2024

iisaduan commented Oct 1, 2024 • edited Loading

Enable `--isolatedDeclarations` on TS codebase #59635

Enable `--isolatedDeclarations` on TS codebase #59635

iisaduan commented Aug 14, 2024 •

edited

Loading

iisaduan left a comment •

edited

Loading

iisaduan left a comment •

edited

Loading

typescript-bot commented Sep 13, 2024 •

edited

Loading

iisaduan commented Oct 1, 2024 •

edited

Loading