Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in -[NSOperationQueue _doMainWork] #1655

Closed
triplef opened this issue Jan 9, 2017 · 0 comments
Closed

Crash in -[NSOperationQueue _doMainWork] #1655

triplef opened this issue Jan 9, 2017 · 0 comments
Assignees
@ms-jihua
Labels
Area-Foundation Bug
Milestone
1703

Comments

@triplef
Copy link
Contributor

triplef commented Jan 9, 2017

We’re seeing the following crash in NSOperationQueue / NSAtomicList:

HEAP_CORRUPTION_ACTIONABLE_LFHSegmentDoubleFree_DOUBLE_FREE_c0000374_Foundation.dll!NSAtomicListPop

Frame	Image	Function	Offset
0	ntdll	RtlpHpLfhSubsegmentFreeBlock	0xE5	
1	ntdll	RtlpHpSegFree	0x5C	
2	ntdll	RtlpHpFreeHeap	0x18A	
3	ntdll	RtlpFreeHeapInternal	0x4F	
4	ntdll	RtlpHpFreeWithExceptionProtection	0x2E	
5	ntdll	RtlFreeHeap	0x4AADB	
6	ucrtbase	_free_base	0x1B	
7	ucrtbase	free	0x18	
8	Foundation	NSAtomicListPop	0x85	
9	Foundation	RunOperationFromLists	0x96	
10	Foundation	-[NSOperationQueue _doMainWork]	0xD0	
11	Foundation	-[NSOperationQueue _workThread]	0x1B	
12	Foundation	-[NSThread main]	0x4A	
13	Foundation	_threadBody	0x4D	
14	Starboard	ThreadRoutine	0x3F	
15	kernel32	BaseThreadInitThunk	0x24	
16	ntdll	__RtlUserThreadStart	0x2F	
17	ntdll	_RtlUserThreadStart	0x1B
@rajsesh rajsesh added this to the 1701 milestone Jan 9, 2017
@bbowman bbowman closed this as completed Jan 11, 2017
@ashvarma ashvarma reopened this Jan 27, 2017
@rajsesh rajsesh modified the milestones: 1701, 1702 Feb 2, 2017
@rajsesh rajsesh assigned ms-jihua and unassigned bbowman Feb 9, 2017
@rajsesh rajsesh modified the milestones: 1702, 1703 Feb 28, 2017
ms-jihua added a commit that referenced this issue Mar 15, 2017
@ms-jihua
Re-implement NSOperationQueue
047931f 
- Add support for
    - queuePriority
    - underlyingQueue
    - currentQueue
    - maxConcurrentOperationCount
    - KVO-compliance
- Fixes some edge cases (ie: hanging on certain non-ready operations)
- Add unit tests
- Add performance benchmark tests

Fixes #2228
Fixes #1655
Fixes #869
@ms-jihua ms-jihua mentioned this issue Mar 15, 2017
Merged
ms-jihua added a commit that referenced this issue Mar 17, 2017
@ms-jihua
Re-implement NSOperationQueue
ac3f342 
- Add support for
    - queuePriority
    - underlyingQueue
    - currentQueue
    - maxConcurrentOperationCount
    - KVO-compliance
- Fixes some edge cases (ie: hanging on certain non-ready operations)
- Add unit tests
- Add performance benchmark tests

Fixes #2228
Fixes #1655
Fixes #869
ms-jihua added a commit that referenced this issue Mar 20, 2017
@ms-jihua
Re-implement NSOperationQueue
49fa528 
- Add support for
    - queuePriority
    - underlyingQueue
    - currentQueue
    - maxConcurrentOperationCount
    - KVO-compliance
- Fixes some edge cases (ie: hanging on certain non-ready operations)
- Add unit tests
- Add performance benchmark tests

Fixes #2228
Fixes #1655
Fixes #869
ms-jihua added a commit that referenced this issue Mar 20, 2017
@ms-jihua
Re-implement NSOperationQueue (#2240)
7104259 
* Re-implement NSOperationQueue
- Add support for
    - queuePriority
    - underlyingQueue
    - currentQueue
    - maxConcurrentOperationCount
    - KVO-compliance
- Fixes some edge cases (ie: hanging on certain non-ready operations)
- Add unit tests
- Add performance benchmark tests

Fixes #2228
Fixes #1655
Fixes #869

* - Address CR feedback
- Actually implement queuePriority this time
- Perf numbers did not meaningfully change from last iteration

* minor cr feedback

* minor cr feedback

* move test for currentQueue == mainQueue on main thread to functional tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ms-jihua ms-jihua

Labels
Area-Foundation Bug
Projects
None yet
Milestone
1703
Development

No branches or pull requests
5 participants
@triplef @ashvarma @rajsesh @bbowman @ms-jihua