Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for NSOperation queuePriority #2228

Closed
triplef opened this issue Mar 14, 2017 · 1 comment
Closed

Add support for NSOperation queuePriority #2228

triplef opened this issue Mar 14, 2017 · 1 comment
Assignees
@rajsesh @ms-jihua
Labels
Area-Foundation

Comments

@triplef
Copy link
Contributor

triplef commented Mar 14, 2017

We would like to see support for NSOperation.queuePriority to change the relative priority of an operation in a queue.

This might depend on or be part of #869.
ms-jihua added a commit that referenced this issue Mar 15, 2017
@ms-jihua
Re-implement NSOperationQueue
047931f 
- Add support for
    - queuePriority
    - underlyingQueue
    - currentQueue
    - maxConcurrentOperationCount
    - KVO-compliance
- Fixes some edge cases (ie: hanging on certain non-ready operations)
- Add unit tests
- Add performance benchmark tests

Fixes #2228
Fixes #1655
Fixes #869
@ms-jihua ms-jihua mentioned this issue Mar 15, 2017
Merged
ms-jihua added a commit that referenced this issue Mar 17, 2017
@ms-jihua
Re-implement NSOperationQueue
ac3f342 
- Add support for
    - queuePriority
    - underlyingQueue
    - currentQueue
    - maxConcurrentOperationCount
    - KVO-compliance
- Fixes some edge cases (ie: hanging on certain non-ready operations)
- Add unit tests
- Add performance benchmark tests

Fixes #2228
Fixes #1655
Fixes #869
@rajsesh
Copy link
Contributor

rajsesh commented Mar 20, 2017

@ms-jihua has this implemented as part of #2240

@rajsesh rajsesh closed this as completed Mar 20, 2017
ms-jihua added a commit that referenced this issue Mar 20, 2017
@ms-jihua
Re-implement NSOperationQueue
49fa528 
- Add support for
    - queuePriority
    - underlyingQueue
    - currentQueue
    - maxConcurrentOperationCount
    - KVO-compliance
- Fixes some edge cases (ie: hanging on certain non-ready operations)
- Add unit tests
- Add performance benchmark tests

Fixes #2228
Fixes #1655
Fixes #869
ms-jihua added a commit that referenced this issue Mar 20, 2017
@ms-jihua
Re-implement NSOperationQueue (#2240)
7104259 
* Re-implement NSOperationQueue
- Add support for
    - queuePriority
    - underlyingQueue
    - currentQueue
    - maxConcurrentOperationCount
    - KVO-compliance
- Fixes some edge cases (ie: hanging on certain non-ready operations)
- Add unit tests
- Add performance benchmark tests

Fixes #2228
Fixes #1655
Fixes #869

* - Address CR feedback
- Actually implement queuePriority this time
- Perf numbers did not meaningfully change from last iteration

* minor cr feedback

* minor cr feedback

* move test for currentQueue == mainQueue on main thread to functional tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rajsesh rajsesh

@ms-jihua ms-jihua

Labels
Area-Foundation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@triplef @ashvarma @rajsesh @ms-jihua