Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListView is incorrectly mentioned in GridView's comments #1130

Closed
zoltanfGH opened this issue Nov 30, 2022 · 1 comment
Closed

ListView is incorrectly mentioned in GridView's comments #1130

zoltanfGH opened this issue Nov 30, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@zoltanfGH
Copy link

Which version of the app?

WinUI 3 Gallery

Description

On the GridView Page under Grid View with Layout Customization, the source code comment says "<!-- In this example, the ListView's ItemTemplate......."

It should be GridView and not ListView.

Screenshots

No response

Windows version

Windows 11 22H2 (22621)

Additional context

No response
@zoltanfGH zoltanfGH added the bug Something isn't working label Nov 30, 2022
@bpulliam bpulliam changed the title Bug title ListView is incorrectly mentioned in GridView's comments Nov 30, 2022
@MarkBrainfire
Copy link
Contributor

MarkBrainfire commented Mar 2, 2023 •
edited

I'll be happy to fix this. Done. It's a silly typo fix in a comment. Hit the merge button already.

@MarkBrainfire MarkBrainfire mentioned this issue Mar 2, 2023
Merged
2 tasks
marcelwgn pushed a commit that referenced this issue Mar 3, 2023
@MarkBrainfire
#1130 Modified source code comment to refer to GridView instead of Li…
a85a24e 
…stView and to use correct name: "ImageOverlayTemplate" (#1204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bpulliam @marcelwgn @zoltanfGH @MarkBrainfire