Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1130 Corrected source code comments displayed to user #1204

Merged
merged 1 commit into from
Mar 3, 2023
Merged

#1130 Corrected source code comments displayed to user #1204

merged 1 commit into from
Mar 3, 2023

Conversation

MarkBrainfire
Copy link
Contributor

@MarkBrainfire MarkBrainfire commented Mar 2, 2023

Changed ListView to GridView and changed the template name to ImageOverlayTemplate.

Description

On the GridView control page in the second "GridView with Layout Customization" example, within the comments of the psuedo XAML code I changed the erroneous reference to "ListView" to the correct reference of "GridView" and corrected the template name to "ImageOverlayTemplate".

Motivation and Context

This resolves issue #1130
The incorrect comment that existed previously would be confusing to a user attempting to follow the provided psuedo source code.

How Has This Been Tested?

I ran the corrected version of WinUI Gallery on my local computer and the comment is now displaying correctly. See screen shot below.

Screenshots (if appropriate):

Changes

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

…stView and to use correct name: "ImageOverlayTemplate"
Copy link
Collaborator

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@marcelwgn marcelwgn merged commit a85a24e into microsoft:main Mar 3, 2023
@MarkBrainfire MarkBrainfire deleted the listview-to-gridview_#1130 branch March 3, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants