Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX] MinWidth should be defined #1181

Closed
niels9001 opened this issue Jan 25, 2023 · 5 comments · Fixed by #1404
Closed

[UX] MinWidth should be defined #1181

niels9001 opened this issue Jan 25, 2023 · 5 comments · Fixed by #1404
Assignees
@marcelwgn
Labels
accessibility Issues related to accessibility bug Something isn't working design Issues with design/layout

Comments

@niels9001
Copy link
Collaborator

Which version of the app?

WinUI 3 Gallery

Description

The current implementation allows for extreme minimal widths, breaking the entire UI.

Should be a MinWidth (e.g 480?) to avoid this behavior.

Screenshots

image

Windows version

No response

Additional context

No response
@niels9001 niels9001 added the bug Something isn't working label Jan 25, 2023
@gregwoo-microsoft
Copy link
Contributor

@niels9001 Did the Toolkit already implement code to fix this? Wondering if we can port it over to this app.

@marcelwgn
Copy link
Collaborator

I'm afraid the best way to do this currently is to do this: microsoft/microsoft-ui-xaml#2945 (comment)

The Toolkit Sample app is still UWP it seems so they have it a bit easier.

@Mysterious-Dev
Copy link

WinUI Ex makes it easier to set the minimum size. But then it's an extra dependency.

https://github.com/dotMorten/WinUIEx/

@Jay-o-Way
Copy link
Contributor

I always would recommend against a third-party dependency. Especially for an app like this. This should be as native as possible.

@Jay-o-Way Jay-o-Way mentioned this issue Sep 28, 2023
Merged
3 tasks
@Jay-o-Way
Copy link
Contributor

is Subclassing an option?

@karkarl karkarl added accessibility Issues related to accessibility design Issues with design/layout labels Nov 9, 2023
@marcelwgn marcelwgn mentioned this issue Nov 12, 2023
Merged
3 tasks
karkarl pushed a commit that referenced this issue Jan 17, 2024
@marcelwgn @niels9001
Add minimum window sizes (#1404)
9134fbe 
## Description
Adding a minimum size for the apps window and also the TabView tearout
sample for better user experience.

## Motivation and Context
Closes #1181

Co-authored-by: Niels Laute <niels.laute@live.nl>
karkarl pushed a commit that referenced this issue Jul 15, 2024
@marcelwgn @niels9001 @karkarl
Add minimum window sizes (#1404)
67ca7fb 
## Description
Adding a minimum size for the apps window and also the TabView tearout
sample for better user experience.

## Motivation and Context
Closes #1181

Co-authored-by: Niels Laute <niels.laute@live.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcelwgn marcelwgn

Labels
accessibility Issues related to accessibility bug Something isn't working design Issues with design/layout
Projects
WinUI Gallery Backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add minimum window sizes marcelwgn/WinUI-Gallery
6 participants
@karkarl @niels9001 @marcelwgn @Mysterious-Dev @Jay-o-Way @gregwoo-microsoft