Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum window sizes #1404

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Conversation

marcelwgn
Copy link
Collaborator

Description

Adding a minimum size for the apps window and also the TabView tearout sample for better user experience.

Motivation and Context

Closes #1181

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link

@Mysterious-Dev Mysterious-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@niels9001 niels9001 self-requested a review January 8, 2024 14:21
Copy link
Collaborator

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works well :)! Thanks @chingucoding!

@niels9001
Copy link
Collaborator

@chingucoding I guess we need an empty commit here as well (as part of: #1423 (comment))

@karkarl karkarl merged commit 9134fbe into microsoft:main Jan 17, 2024
2 checks passed
karkarl pushed a commit that referenced this pull request Jul 15, 2024
## Description
Adding a minimum size for the apps window and also the TabView tearout
sample for better user experience.

## Motivation and Context
Closes #1181

Co-authored-by: Niels Laute <niels.laute@live.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UX] MinWidth should be defined
4 participants