Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Escape glyph hex in xaml #1423

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Conversation

HO-COOH
Copy link
Contributor

@HO-COOH HO-COOH commented Jan 3, 2024

Description

Escape glyph hex in xaml sample

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

image
->
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Collaborator

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works well!

@karkarl
Copy link
Collaborator

karkarl commented Jan 12, 2024

I reconfigured the CI pipeline from Azure side. I'm unable to trigger a manual build as it's a forked branch, do you mind pushing a "whitespace" commit to see if it triggers a build?

@HO-COOH
Copy link
Contributor Author

HO-COOH commented Jan 13, 2024

@karkarl Done

@@ -20,7 +20,7 @@
mc:Ignorable="d">

<StackPanel>
<local:ControlExample x:Name="Example1" HeaderText="InfoBadge embedded in NavigationView" HorizontalContentAlignment="Stretch" >
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Unrelated to PR

@marcelwgn marcelwgn merged commit 5fb1e57 into microsoft:main Jan 16, 2024
2 checks passed
@HO-COOH HO-COOH deleted the fix/iconbadge-xaml branch February 5, 2024 08:10
karkarl pushed a commit that referenced this pull request Jul 15, 2024
<!--- Provide a general summary of your changes in the Title above -->

## Description
Escape glyph hex in xaml sample

## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->

## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Screenshots (if appropriate):

![image](https://github.com/microsoft/WinUI-Gallery/assets/42881734/f299b147-1dad-40ca-aacc-fe980c8b14dd)
->

![image](https://github.com/microsoft/WinUI-Gallery/assets/42881734/4252a0b8-f5e2-46e7-b0f2-c59e793c161e)


## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants