-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Escape glyph hex in xaml #1423
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works well!
I reconfigured the CI pipeline from Azure side. I'm unable to trigger a manual build as it's a forked branch, do you mind pushing a "whitespace" commit to see if it triggers a build? |
@karkarl Done |
@@ -20,7 +20,7 @@ | |||
mc:Ignorable="d"> | |||
|
|||
<StackPanel> | |||
<local:ControlExample x:Name="Example1" HeaderText="InfoBadge embedded in NavigationView" HorizontalContentAlignment="Stretch" > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Unrelated to PR
<!--- Provide a general summary of your changes in the Title above --> ## Description Escape glyph hex in xaml sample ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## Screenshots (if appropriate): ![image](https://github.com/microsoft/WinUI-Gallery/assets/42881734/f299b147-1dad-40ca-aacc-fe980c8b14dd) -> ![image](https://github.com/microsoft/WinUI-Gallery/assets/42881734/4252a0b8-f5e2-46e7-b0f2-c59e793c161e) ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change)
Description
Escape glyph hex in xaml sample
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
->
Types of changes