Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless api check in the animation interop page code sample #1418

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

HO-COOH
Copy link
Contributor

@HO-COOH HO-COOH commented Dec 18, 2023

Description

Remove api check in code sample of winui3 animation interop page

Motivation and Context

Because it's unnecessary. WinUI3 has decoupled compositor

How Has This Been Tested?

Manual

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Collaborator

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you for fixing this!

@niels9001
Copy link
Collaborator

@HO-COOH I guess we need an empty commit here as well (as part of: #1423 (comment))

@HO-COOH
Copy link
Contributor Author

HO-COOH commented Jan 18, 2024

@HO-COOH I guess we need an empty commit here as well (as part of: #1423 (comment))

Done

@karkarl karkarl merged commit f7e98f0 into microsoft:main Jan 31, 2024
2 checks passed
karkarl pushed a commit that referenced this pull request Jul 15, 2024
…1418)

<!--- Provide a general summary of your changes in the Title above -->

## Description
Remove api check in code sample of winui3 animation interop page

## Motivation and Context
Because it's unnecessary. WinUI3 has decoupled compositor

## How Has This Been Tested?
Manual

## Screenshots (if appropriate):

## Types of changes
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants