Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Viewbox Control has been Disabled #1202

Closed
MarkBrainfire opened this issue Mar 2, 2023 · 2 comments
Closed

The Viewbox Control has been Disabled #1202

MarkBrainfire opened this issue Mar 2, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@MarkBrainfire
Copy link
Contributor

MarkBrainfire commented Mar 2, 2023 •
edited

Which version of the app?

WinUI 3 Gallery 1.3.17.0

Description

The Viewbox control is one of the most important WinUI 3 controls and essential for a major application I'm developing.

Yet it appears the Viewbox control has been disabled deliberately.

Ironically, I came to this repos today to offer to enhance the WinUI 3 Gallery Viewbox page.

ViewBox.Disabled.mp4

Screenshots

No response

Windows version

Windows 11 22H2 (22621)

Additional context

No response
@MarkBrainfire MarkBrainfire added the bug Something isn't working label Mar 2, 2023
@MarkBrainfire MarkBrainfire changed the title The ViewBox Contral has been Disabled The ViewBox Control has been Disabled Mar 2, 2023
@MarkBrainfire MarkBrainfire changed the title The ViewBox Control has been Disabled The Viewbox Control has been Disabled Mar 2, 2023
@marcelwgn
Copy link
Collaborator

@bpulliam @gregwoo-microsoft Do you happen to know why the page was removed?

@MarkBrainfire
Copy link
Contributor Author

MarkBrainfire commented Mar 4, 2023 •
edited

@chingucoding @bpulliam @gregwoo-microsoft
Yes. Someone used the wrong name for this control: ViewBox instead of Viewbox. This causes the dynamically assembled type string to be null and there's a line of code that checks for this and disables the control when this occurs. The data in the json file is already correct.

But there's more going on than just a simple name fix. There are XAML parsing errors under some circumstances.

Don't bother assigning this to anyone. Hopefully I'll have a merge request for you soon, but I must be absolutely sure to find out why there are XAML parsing errors and make sure they never occur.

This was referenced Mar 4, 2023
Closed
Merged
bpulliam pushed a commit that referenced this issue Mar 7, 2023
@MarkBrainfire
#1202 Restore Viewbox to Gallery (#1209)
d3e49d6 
* Restore the Viewbox control by renaming class ViewBoxPage to ViewboxPage.  Also renamed the  corresponding files (xaml and xaml.cs) as well renaming ViewBox.png to Viewbox.png, and ViewBoxIcon.png to ViewboxIcon.png and renaming all other occurances of ViewBox to Viewbox in includes and comments.

* Rename ViewBoxPage.xaml to ViewboxPage.xaml

* Rename ViewBoxPage.xaml.cs to ViewboxPage.xaml.cs

* Remove ViewboxIcon.png (which git still thinks is ViewBoxIcon.png) in order to commit  and add back later so that git will record that this file has been renamed.

* Added back the original file ViewboxIcon.png so git will get that this file has been renamed.   (amazing that I have to do this)  Good grief!

* Removed Viewbox.png (to add it later -- this appears to be the only way for git to track file name changes!)

* Adding back an identical file to force git to acknowledge that the name has changed.
@bpulliam bpulliam closed this as completed Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bpulliam @marcelwgn @MarkBrainfire