#1202 Restore Viewbox to Gallery #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age. Also renamed the corresponding files (xaml and xaml.cs) as well renaming ViewBox.png to Viewbox.png, and ViewBoxIcon.png to ViewboxIcon.png and renaming all other occurances of ViewBox to Viewbox in includes and comments.
… order to commit and add back later so that git will record that this file has been renamed.
…s file has been renamed. (amazing that I have to do this) Good grief!
…ay for git to track file name changes!)
bpulliam
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename ViewBox to Viewbox to restore access to the Viewbox control page to the Gallery.
This resolves issue #1202
Description
Renames included:
ViewBoxPage class -> ViewboxPage
ViewBoxPage.xaml filename -> ViewboxPage.xaml
ViewBoxPage.xaml.cs filename -> ViewboxPage.xaml.cs
ViewBoxIcon.png filename -> ViewboxIcon.png
ViewBox.png filename -> Viewbox.png
Content Include Items:
"Assets\ControlIcons\ViewBoxIcon.png" to "Assets\ControlIcons\ViewboxIcon.png"
"Assets\ControlImages\ViewBox.png" to "Assets\ControlImages\Viewbox.png"
Several occurrences of ViewBox -> Viewbox in ControlInfoData.json items.
Motivation and Context
Improper spelling of ViewBox resulted in a null page type and then the Viewbox control not being included in the build.
This subsequently caused both the menu item and control item to be disabled and ghosted, this making it impossible to access the Viewbox page.
How Has This Been Tested?
I compiled and ran the gallery and then accessed the Viewbox control page in every possible way and observed that the page functioned properly.
IMPORTANT NOTE!!!!!! Accessing the Viewbox and other controls multiple times (2 to 10 times usually) results in a XamlParseException. See issue #1206.
Types of changes