Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a custom showmode example in flyout page #1133

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

HO-COOH
Copy link
Contributor

@HO-COOH HO-COOH commented Dec 3, 2022

Description

As title.

Motivation and Context

Found something not working about changing the flyout mode in the current version of winui, so I added this example and confirmed it.
The issue here

How Has This Been Tested?

Manually

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@niels9001
Copy link
Collaborator

@HO-COOH Would you mind rebasing this PR? Wasn't able to test it due to a targetframework error that should be resolved with main.

@karkarl
Copy link
Collaborator

karkarl commented Oct 17, 2023

Thanks for creating the sample. I'll route the bug internally to get a fix in.

@karkarl karkarl merged commit 820a8e9 into microsoft:winui2 Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants