Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing FlyoutShowMode does not take effect #7987

Closed
HO-COOH opened this issue Dec 3, 2022 · 3 comments
Closed

Changing FlyoutShowMode does not take effect #7987

HO-COOH opened this issue Dec 3, 2022 · 3 comments
Labels
bug Something isn't working closed-Fixed Described behavior has been fixed. fix-released The fix has been in a release (experimental, preview, stable, or servicing). team-Controls Issue for the Controls team
Milestone

Comments

@HO-COOH
Copy link

HO-COOH commented Dec 3, 2022

Describe the bug

Setting the ShowMode of a Flyout does not take effect. See the pull request here for an example. Even setting it manually in xaml like this

                <Button Content="Click for flyout">
                    <Button.Flyout>
                        <Flyout x:Name="CustomFlyout" ShowMode="Transient">
                            <TextBlock Text="This is a flyout"/>
                        </Flyout>
                    </Button.Flyout>
                </Button>

I would still get Standard mode when the flyout is opened, as this suggests

            <local:ControlExample.Xaml>
                <x:String xml:space="preserve">
&lt;Button Content="Click for flyout"&gt;
    &lt;Button.Flyout&gt;
        &lt;Flyout ShowMode="$(ShowMode)"&gt;
            &lt;TextBlock Text="This is a flyout" /&gt;
        &lt;/Flyout&gt;
    &lt;/Button.Flyout&gt;
&lt;/Button&gt;
                </x:String>
            </local:ControlExample.Xaml>
            <local:ControlExample.Substitutions>
                <local:ControlExampleSubstitution Key="ShowMode" Value="{x:Bind CustomFlyout.ShowMode, Mode=OneWay}"/>
            </local:ControlExample.Substitutions>
        </local:ControlExample>

Steps to reproduce the bug

See above

Expected behavior

No response

Screenshots

flyout

NuGet package version

WinUI 2 - Microsoft.UI.Xaml 2.8.1

Windows version

Windows 11 (22H2): Build 22621

Additional context

No response

@HO-COOH HO-COOH added the bug Something isn't working label Dec 3, 2022
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Dec 3, 2022
@bpulliam bpulliam added team-Controls Issue for the Controls team product-winui2 and removed needs-triage Issue needs to be triaged by the area owners labels Dec 5, 2022
@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@HO-COOH
Copy link
Author

HO-COOH commented Aug 1, 2023

Still reproducible with WinUI 2.8.5 package.

karkarl pushed a commit to microsoft/WinUI-Gallery that referenced this issue Oct 17, 2023
<!--- Provide a general summary of your changes in the Title above -->

## Description
As title.

## Motivation and Context
Found something not working about changing the flyout mode in the
current version of winui, so I added this example and confirmed it.
The [issue
here](microsoft/microsoft-ui-xaml#7987)

## How Has This Been Tested?
Manually

## Screenshots (if appropriate):

![image](https://user-images.githubusercontent.com/42881734/205444921-2b51f446-9b4a-4ca2-aaed-4a8070c2d3c2.png)

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
@ranjeshj
Copy link
Contributor

This repros in WinUI3. @HO-COOH good find.

@llongley llongley closed this as completed Feb 9, 2024
@llongley llongley added the closed-Fixed Described behavior has been fixed. label Feb 9, 2024
@codendone codendone added this to the WinAppSDK 1.6 milestone Feb 22, 2024
@codendone codendone added the fix-released The fix has been in a release (experimental, preview, stable, or servicing). label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working closed-Fixed Described behavior has been fixed. fix-released The fix has been in a release (experimental, preview, stable, or servicing). team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

5 participants