Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to WASDK 1.4 and related maintenance #1336

Merged
merged 14 commits into from
Aug 30, 2023

Conversation

Scottj1s
Copy link
Member

@Scottj1s Scottj1s commented Aug 25, 2023

A bit of a hodgepodge PR:
Update to WASDK 1.4
Work around menu theme regression with 1.4
Eliminate WindowsAppSDK-VersionInfo.cs duplicate source warning
Remove bogus patch number
Support self-contained
Add publish profiles
Disable debug publish optimizations (inner loop)
Remove wapproj cruft

@Scottj1s Scottj1s requested a review from bpulliam August 25, 2023 16:49
@Scottj1s
Copy link
Member Author

See also:
microsoft/WindowsAppSDK#3819

@Scottj1s Scottj1s changed the title Ensure that WindowsAppSDK-VersionInfo.cs is added to compile items before XamlPreCompile, to remove dupe Fix PageHeader.xaml build break, WindowsAppSDK-VersionInfo.cs warning, add publish profiles, support self-contained Aug 25, 2023
@Scottj1s Scottj1s changed the title Fix PageHeader.xaml build break, WindowsAppSDK-VersionInfo.cs warning, add publish profiles, support self-contained Fix PageHeader.xaml build break, WindowsAppSDK-VersionInfo.cs warning, support self-contained, add publish profiles, optimize debug publish Aug 25, 2023
@Scottj1s Scottj1s changed the title Fix PageHeader.xaml build break, WindowsAppSDK-VersionInfo.cs warning, support self-contained, add publish profiles, optimize debug publish Fix PageHeader.xaml build break, WindowsAppSDK-VersionInfo.cs warning, support self-contained, add publish profiles, disable debug publish optimization Aug 25, 2023
@Scottj1s
Copy link
Member Author

Note: build failing because in Microsoft.WindowsAppSDK.DeploymentManager.CS.targets, the target GenerateDeploymentManagerCS renamed to GenerateBootstrapCS between 1.3 and 1.4. When 1.4 is released, I'll update this PR to use it, which should resolve the build issue.

@bpulliam
Copy link
Contributor

Note: build failing because in Microsoft.WindowsAppSDK.DeploymentManager.CS.targets, the target GenerateDeploymentManagerCS renamed to GenerateBootstrapCS between 1.3 and 1.4. When 1.4 is released, I'll update this PR to use it, which should resolve the build issue.

We should be sure to relnote this. We should also provide a less brittle way of doing this (or move this into our props/targets so that every app who wants the version number can get it easily).

@Scottj1s Scottj1s changed the title Fix PageHeader.xaml build break, WindowsAppSDK-VersionInfo.cs warning, support self-contained, add publish profiles, disable debug publish optimization Update to WASDK 1.4, work around menu theme regression, remove WindowsAppSDK-VersionInfo.cs warning, support self-contained, add publish profiles, disable debug publish optimization Aug 30, 2023
@Scottj1s Scottj1s changed the title Update to WASDK 1.4, work around menu theme regression, remove WindowsAppSDK-VersionInfo.cs warning, support self-contained, add publish profiles, disable debug publish optimization Update to WASDK 1.4 and related maintenance Aug 30, 2023
@Scottj1s
Copy link
Member Author

Note: build failing because in Microsoft.WindowsAppSDK.DeploymentManager.CS.targets, the target GenerateDeploymentManagerCS renamed to GenerateBootstrapCS between 1.3 and 1.4. When 1.4 is released, I'll update this PR to use it, which should resolve the build issue.

We should be sure to relnote this. We should also provide a less brittle way of doing this (or move this into our props/targets so that every app who wants the version number can get it easily).

good idea - updated the related WinAppSDK PR to simply use a property for including version info exactly once, before any compilation

@Scottj1s Scottj1s closed this Aug 30, 2023
@Scottj1s Scottj1s reopened this Aug 30, 2023
@Scottj1s Scottj1s merged commit a696058 into main Aug 30, 2023
2 checks passed
@Scottj1s Scottj1s deleted the scottj1s/version_info_dupe_warning branch August 30, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants