Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simply add auto initializer sources without a target, and define a user-available property to add WindowsAppSDK-VersionInfo.cs exactly once #3819

Merged
merged 3 commits into from
Aug 30, 2023

Conversation

Scottj1s
Copy link
Member

No description provided.

@Scottj1s
Copy link
Member Author

See also:
microsoft/WinUI-Gallery#1336

…fo.cs exactly once for all compilations (Xaml, etc)
@Scottj1s Scottj1s changed the title Use CoreCompileDependsOn to ensure that version info is added before XamlPreCompile, not just CoreCompile Simply add auto initializer sources without a target, and define a user-available property to add WindowsAppSDK-VersionInfo.cs exactly once Aug 30, 2023
@Scottj1s
Copy link
Member Author

/azp run

@Scottj1s Scottj1s enabled auto-merge (squash) August 30, 2023 20:51
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Scottj1s Scottj1s merged commit 043d811 into main Aug 30, 2023
14 checks passed
@Scottj1s Scottj1s deleted the scottj1s/versioninfo_xamlprecompile branch August 30, 2023 21:34
Scottj1s added a commit that referenced this pull request Sep 18, 2023
…er-available property to add WindowsAppSDK-VersionInfo.cs exactly once (#3819)

* Use CoreCompileDependsOn to ensure that version info is added before XamlPreCompile, not just CoreCompile

* restructured to enable apps to easily include WindowsAppSDK-VersionInfo.cs exactly once for all compilations (Xaml, etc)

* removed cruft target
Scottj1s added a commit that referenced this pull request Sep 20, 2023
…lable property to add WindowsAppSDK-VersionInfo.cs exactly once (#3860)

* Simply add auto initializer sources without a target, and define a user-available property to add WindowsAppSDK-VersionInfo.cs exactly once (#3819)

* Use CoreCompileDependsOn to ensure that version info is added before XamlPreCompile, not just CoreCompile

* restructured to enable apps to easily include WindowsAppSDK-VersionInfo.cs exactly once for all compilations (Xaml, etc)

* removed cruft target

* Update WindowsAppSDK-RunTestsInPipeline-Job.yml (#3798)

Stop running tests on 21h1 OS image because this version has reached end of support, and the image is no longer in the test VM pool.

---------

Co-authored-by: alexlamtest <68841560+alexlamtest@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants