-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: filename containing invalid characters to be used as docker image name #1069
Comments
Related to #1095. The input filename should be validated and the docker image name should be validated |
3 tasks
3 tasks
joshkyh
pushed a commit
that referenced
this issue
Jan 17, 2024
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this issue
Apr 17, 2024
…rosoft#1069 (microsoft#1127) * fix microsoft#1069 * uncomment skips * use importlib to check package * better code --------- Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
https://github.com/microsoft/autogen/actions/runs/7338570361/job/19981290015?pr=925
The first line in the python block is:
# filename: inequality.py (you can choose your own filename)
The filename is parsed as
inequality.py (you can choose your own filename)
by:autogen/autogen/agentchat/conversable_agent.py
Line 1121 in d583ad8
It then causes the error in
autogen/autogen/code_utils.py
Lines 401 to 402 in d583ad8
Steps to reproduce
call
execute_code(filename="inequality.py (you can choose your own filename", use_docker=True, code="")
Expected Behavior
An error like https://github.com/microsoft/autogen/actions/runs/7338570361/job/19981290015?pr=925 should occur
at
autogen/autogen/code_utils.py
Lines 401 to 402 in d583ad8
Screenshots and logs
https://github.com/microsoft/autogen/actions/runs/7338570361/job/19981290015?pr=925
Additional Information
AutoGen Version: 0.2.2
The text was updated successfully, but these errors were encountered: